feat: add webUI to profiler #4544
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hongkuanz <[email protected]>
hhzhang16
reviewed
Nov 24, 2025
Contributor
hhzhang16
left a comment
hhzhang16
left a comment
There was a problem hiding this comment.
Can you include screenshots or a short demo in the MR description?
| AIPERF_PREFILL_ATTN_DP_NUM_REQ_RATIO = 4 | ||
|
|
||
| # Cost calculation defaults | ||
| GPU_COST_PER_HOUR = 3.0 # Cost per GPU per hour in dollars |
Contributor
There was a problem hiding this comment.
Is this consistent among all our GPUs?
| logger.addHandler(console_handler) | ||
|
|
||
| # Color palette for chart datasets | ||
| CHART_COLORS = [ |
Contributor
There was a problem hiding this comment.
if p_idx ever exceeds 8, the colors will be repeated; is that expected functionality?
| "#7f7f7f", # gray | ||
| ] | ||
|
|
||
| WEB_UI_SELECTION_TIMEOUT = 3600 |
Contributor
There was a problem hiding this comment.
This is a long timeout (1 hour), maybe it should be shorter
Comment on lines
+66
to
+70
| data["prefill"]["chart"]["target_line"]["value"] = args.ttft | ||
| data["prefill"]["chart"]["target_line"]["label"] = f"Target TTFT: {args.ttft} ms" | ||
|
|
||
| data["decode"]["chart"]["target_line"]["value"] = args.itl | ||
| data["decode"]["chart"]["target_line"]["label"] = f"Target ITL: {args.itl} ms" |
Contributor
There was a problem hiding this comment.
Is the UI user aware that we set defaults if they do not choose to set it?
parser.add_argument(
"--ttft",
type=float,
default=config.get("sla", {}).get("ttft", 50.0),
help="target Time To First Token (float, in milliseconds)",
)
parser.add_argument(
"--itl",
type=float,
default=config.get("sla", {}).get("itl", 10.0),
help="target Inter Token Latency (float, in milliseconds)",
)
| logger.info(f"Selection received: {plot_type}, row {row_idx}") | ||
|
|
||
| # Store selection for later confirmation | ||
| if plot_type == "cost": |
Contributor
There was a problem hiding this comment.
Is this stored locally/ephemerally?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
Details:
Where should the reviewer start?
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)