-
Notifications
You must be signed in to change notification settings - Fork 3
Generalize scripts for building prognostic run environment #2035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
40c453d
to
9b6fcb4
Compare
I rebuilt and pushed the regular and GPU base images on my VM after 86e0855 (and before pushing the commit to GitHub). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Easier to read Dockerfile and useful for installing on other platforms.
Only suggested change is to parametrize the list of internal python dependencies.
This PR generalizes some scripts used in building the prognostic run docker image so that they can also be used in building code on Gaea or other platforms. I plan on making a followup PR with the code to actually create the environment on Gaea (this will involve updates to the fortran repo as well).
Coverage reports (updated automatically):