Skip to content

Generalize scripts for building prognostic run environment #2035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 12, 2022

Conversation

spencerkclark
Copy link
Member

@spencerkclark spencerkclark commented Sep 9, 2022

This PR generalizes some scripts used in building the prognostic run docker image so that they can also be used in building code on Gaea or other platforms. I plan on making a followup PR with the code to actually create the environment on Gaea (this will involve updates to the fortran repo as well).

Coverage reports (updated automatically):

  • test_unit: 83%

@spencerkclark spencerkclark force-pushed the generalize-build-scripts branch from 40c453d to 9b6fcb4 Compare September 12, 2022 15:04
@spencerkclark
Copy link
Member Author

spencerkclark commented Sep 12, 2022

I rebuilt and pushed the regular and GPU base images on my VM after 86e0855 (and before pushing the commit to GitHub).

@spencerkclark spencerkclark marked this pull request as ready for review September 12, 2022 16:36
Copy link
Contributor

@oliverwm1 oliverwm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Easier to read Dockerfile and useful for installing on other platforms.

Only suggested change is to parametrize the list of internal python dependencies.

@spencerkclark spencerkclark enabled auto-merge (squash) September 12, 2022 20:34
@spencerkclark spencerkclark changed the title Add generic scripts to aid in building the prognostic run environment Generalize scripts for building prognostic run environment Sep 12, 2022
@spencerkclark spencerkclark merged commit 61c6fe0 into master Sep 12, 2022
@spencerkclark spencerkclark deleted the generalize-build-scripts branch September 12, 2022 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants