Skip to content

fix: Recharts dimension warnings + DevTools settings toggle#55

Merged
aicayzer merged 1 commit into
mainfrom
cc/brave-volhard-b6b3f8
May 12, 2026
Merged

fix: Recharts dimension warnings + DevTools settings toggle#55
aicayzer merged 1 commit into
mainfrom
cc/brave-volhard-b6b3f8

Conversation

@aicayzer
Copy link
Copy Markdown
Owner

Summary

  • Fix `width(-1)/height(-1)` Recharts warnings in `ActivityArea`, `DistBar`, `LineTrend`, and `PaceTrend` by setting `initialDimension={{ width: 1, height: 1 }}` on each `ResponsiveContainer` — overrides the -1 sentinel Recharts uses before ResizeObserver fires
  • Add a persistent Enable DevTools toggle in Settings → About → Developer card, wired through the full stack (Config type → config.ts → ipc.ts → api.ts → configStore → Settings UI); DevTools also auto-open on launch when the setting is on

Test plan

  • Open app — no `width(-1)/height(-1)` console warnings on any analytics screen
  • Settings → About → Developer → toggle Enable DevTools on → DevTools panel opens
  • Toggle off → DevTools closes
  • Quit and relaunch with toggle on → DevTools auto-open on startup
  • Reset app → devTools resets to false
  • All quality gates pass: `pnpm typecheck && pnpm lint && pnpm format:check && pnpm test`

@aicayzer aicayzer merged commit 8388a4e into main May 12, 2026
3 checks passed
@aicayzer aicayzer deleted the cc/brave-volhard-b6b3f8 branch May 12, 2026 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant