fix(release): unbreak install-note step and auto-publish drafts#67
Merged
Conversation
Two fixes to the release workflow, both surfaced by the v0.3.0 release: 1. The heredoc that builds the install-note text contained the word `don't`. Inside the `NOTE=$(cat <<EOF ... EOF)` command substitution bash treats the apostrophe as an unmatched single quote, failing the step with `unexpected EOF while looking for matching '`. Reword to `do not` — minimal-blast-radius fix; no need to switch heredoc styles. 2. electron-builder's default `releaseType` is `draft`, so even after the install note is appended the release stays as a draft. v0.3.0 had to be promoted to published manually. Add an explicit `gh release edit "$TAG" --draft=false` so future releases auto-publish.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two fixes to
.github/workflows/release.yml, both surfaced by the v0.3.0 release:don't. Inside the surroundingNOTE=$(cat <<EOF ... EOF)command substitution, bash interprets the apostrophe as an unmatched single quote, failing the step withunexpected EOF while looking for matching '. Reword todo not.releaseTypeisdraft, so even with the install-note step working, the release stayed as a draft and had to be promoted manually. Addgh release edit "$TAG" --draft=falseso future releases auto-publish.Why now
v0.3.0 hit both: the install-note step failed, and the release was a draft. I fixed both manually on the v0.3.0 release. This PR makes future tag pushes work end-to-end without intervention.
Test plan