add Watson discovery notebook

[MichaelClifford]

Related Issues and Dependencies

#40

This introduces a breaking change

• Yes
• No

This Pull Request implements

Adding the incomplete demo notebook from the Watson NLU workshop that we will modify to recreate out keyword analysis work.

Description

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[oindrillac]

@MichaelClifford thanks. Just a small nit - can we add a url to the source of the notebook/workshop just for code referencing purposes? 🙂

[MichaelClifford]

@oindrillac added the following markdown to the top of the notebook:'

[oindrillac]

🚢

[tumido]

Can we load these values from environment if they are not defined or it's executed from automation?

Reply via ReviewNB

[tumido]

I think the prints here deserve a function. Something like:

from pprint import pprint
def describe_result(heading, obj):

print(f'"{heading}"\n')

pprint(obj, indent=3)

Or you can even consider printing it as a table from a pandas data frame... The data is fortunately consistent, so pandas should be able to auto-format it.

Reply via ReviewNB

[tumido]

This reminds me that we should update our license...

https://github.com/aicoe-aiops/mailing-list-analysis-toolkit/blob/master/LICENSE

Reply via ReviewNB

[tumido]

if my comments are missing the point and you're just simply trying to copy a notebook over in here, feel free to dismiss my review 🙂

[MichaelClifford]

Hey @tumido, all good points 😄 , and we should incorporate them into upcoming PR's on this notebook. But as you pointed out, this specific PR was just to include an existing notebook that @oindrillac and I are going to modify to meet our needs for testing out some IBM Watson NLU/Discovery features.

The ultimate goal for this notebook though should be to add another "analyses" notebook to our workflow (see #40)