Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added minimal test for DD, DT neutron energy #23

Merged

Conversation

shimwell
Copy link
Collaborator

This PR adds some minimal tests for the DTmean and DDmean neutron energy.

This is in preparation and to protect functionality for a follow up PR where I try to change the units to eV and I will want to show that things are still working.

the ci.yml file has also been changed so that these 4 tests run in the CI

Copy link
Owner

@aidancrilly aidancrilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just approving at this stage, not sure if you are adding more tests but these seem sensible to me

@shimwell
Copy link
Collaborator Author

shimwell commented Mar 21, 2024

I'm keen to do more tests at a later date. I'm sure I'll get more ideas while shifting the units to eV. Is it ok to merge this one, then at least these tiny tests will run for any subsequent PR

@aidancrilly
Copy link
Owner

Happy to merge

@aidancrilly aidancrilly merged commit 387bc1d into aidancrilly:master Mar 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants