changed units of DTprimspecmoments to eV #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
This was referenced Mar 25, 2024
aidancrilly
approved these changes
Mar 25, 2024
Closed
shimwell
added a commit
that referenced
this pull request
Mar 25, 2024
Merge pull request #27 from shimwell/changing_primspecmoments_to_ev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the
DTprimspecmomentsandDDprimspecmomentsto accept arguments in units of eV and return units of eV.This is super useful for openmc usage where everything is in eV.
Helps with issue #21
Also some extra tests have been added to check the variance is sized correctly and increases with Tion.
Also some doc strings and types have been added