Port Nemotron-H-4B-Base-8K (nemotron_h) - #219
Open
DarthCeltic wants to merge 2 commits into
Open
Conversation
Adds nvidia/Nemotron-H-4B-Base-8K to the most_models_ported track. Fixed a real converter bug: NemotronHModel mis-detects MoE vs dense via config key presence, but this checkpoints stale MoE config fields (inherited from its 8B MoE parent) have zero matching expert/moe/router tensors across all 311 tensors on direct inspection. Fixed via a standalone monkeypatch wrapper (never touching the vendored submodule). PPL = 9.4458 +/- 1.75431 on WikiText-2 raw, confirmed via real llama-perplexity run on CPU backend. GGUF hosted on Hugging Face (darthceltic85/nemotron-h-4b-base-gguf) since it exceeds GitHub's 2GB release-asset limit.
Member
|
The converter fix and tensor inspection are useful, but Nemotron-H still needs a real full-offload ET-SoC1 execution and a committed deterministic oracle/expected output with an explicit comparison threshold. Host loading and CPU PPL alone cannot validate the ET port. Please pin the hosted GGUF immutably and include the converter-wrapper output hash. Maintainers will then review/adopt the identity/contract and runner policy. |
Commits the exact reproduction command, pinned corpus/artifact hashes, per-chunk + final CPU reference PPL, and an explicit 20% comparison threshold so a full-offload ET-SoC1 run can be independently verified against this reference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nvidia/Nemotron-H-4B-Base-8Kto themost_models_portedtrack (identitynemotron_h), introducing the Nemotron-H hybrid Mamba2/Attention/MLP execution family to the board.NemotronHModel.__init__inconvert_hf_to_gguf.pydecides MoE-vs-dense by checking key presence ofnum_experts_per_tokinModelBase.load_hparams()'s merged config. For this checkpoint that reports a full, plausible-looking MoE config (num_experts_per_tok=2,moe_intermediate_size=7688,n_routed_experts=8) — but direct inspection of both safetensors shards (311 tensors total) finds zero tensors matchingexpert/moe/router. The config fields are stale, almost certainly inherited from Nemotron-H's larger 8B MoE parent during pruning/distillation. Fixed via a standalone monkeypatch wrapper (ported_models/nemotron_h_4b_base/convert_wrapper.py) that hardcodesis_moe=False, treating tensor evidence as authoritative over the misleading config — the vendored submodule is never touched, matching the establishedpythia410mprecedent.sha256=23cf524eaf7cc0c84ffe3dc168a5bacaad10bde2bb9fbaacba431a96b50c9d31), hosted on Hugging Face (darthceltic85/nemotron-h-4b-base-gguf) since it exceeds GitHub's 2 GB release-asset limit.llama.cpp-et, fused Gated Delta Net enabled, 1489-node compute graph, 1 split) and realllama-perplexityagainst WikiText-2 raw gives PPL = 9.4458 +/- 1.75431 — a good, in-range result that also confirms the quantizationRuntimeWarnings seen during conversion were a false alarm.Test plan
benchmark_configin the claim JSON exactly matches.github/ci/benchmark_config.json's newnemotron_h_4b_baseentry