Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash in single_app.ipynb from invalid version #181

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Fix crash in single_app.ipynb from invalid version #181

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
abf0d90
Fix crash in single_app.ipynb from invalid version
danielhollas Nov 19, 2024
4133f29
CI: Run tests on push to main branch
danielhollas Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions home/app_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
from aiidalab.app import AppRemoteUpdateStatus as AppStatus
from aiidalab.app import AppVersion
from jinja2 import Template
from packaging.version import parse
from packaging.version import InvalidVersion, parse

from home.utils import load_logo
from home.widgets import LogOutputWidget, Spinner, StatusHTML
Expand Down Expand Up @@ -258,11 +258,14 @@ def _refresh_prereleases(self, change):
installed_version = app.installed_version

has_prereleases = app.has_prereleases
prerelease_installed = (
parse(installed_version).is_prerelease
if isinstance(installed_version, str)
else False
)
prerelease_installed = False
if isinstance(installed_version, str):
try:
parsed_version = parse(installed_version)
except InvalidVersion:
pass
else:
prerelease_installed = parsed_version.is_prerelease

with self.hold_trait_notifications():
# The checkbox can only be enabled when the app has prereleases,
Expand Down
12 changes: 1 addition & 11 deletions single_app.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,17 +78,7 @@
"source": [
"app_base = AiidaLabApp(name, app_data, AIIDALAB_APPS)\n",
"\n",
"try:\n",
" display(AppManagerWidget(app_base, minimalistic=False))\n",
"except Exception as error:\n",
yakutovicha marked this conversation as resolved.
Show resolved Hide resolved
" display(\n",
" ipw.HTML(\n",
" '<div style=\"font-size: 30px; text-align:center;\">'\n",
" f\"Unable to show app widget due to error: {error}\"\n",
" \"</div>\",\n",
" layout={\"width\": \"600px\"},\n",
" )\n",
" )"
"display(AppManagerWidget(app_base, minimalistic=False))"
]
}
],
Expand Down