🐛 workflow: Fix bugs in EpwPrepWorkChain
#26
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Correctly access `remote_folder` from `epw_source` outputs. - Fix input access logic for `epw_source` code check. - Explicitly pass `structure` input to interpolation and final EPW steps. - Update convergence criterion to use relative difference. - Tighten default `convergence_threshold` in protocol from 0.5 to 0.05.
- Fix logic for selecting Wannier90 workchain class (Optimize vs Bands) based on projection type and reference bands. - Ensure correct inputs are prepared for the selected Wannier90 workchain in `run_wannier90`. - Explicitly pass `structure` to `EpwBaseWorkChain` inputs. - Update exit code messages for better clarity. - Update protocol to include `aiida.mmn` and `aiida.bvec` in `remote_symlink_list`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wannier90OptimizeWorkChainorWannier90BandsWorkChainupon the existence ofreference_bandsinput.namespace="epw_base"is out of the scope of functionexposed_inputsinrun_epwaiida.mmnandaiida.bvecin stash list since they are used in EPW v6.0