Dumping: Check non-empty input node repositories #6734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeigerJ2
changed the title
GeigerJ2
force-pushed
the
dump/no-empty-node_inputs-dir
branch
from
2c24457 to
ebf6314
Compare
GeigerJ2
force-pushed
the
dump/no-empty-node_inputs-dir
branch
from
1709121 to
9e58538
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6734 +/- ##
==========================================
+ Coverage 78.09% 78.09% +0.01%
==========================================
Files 564 564
Lines 42544 42549 +5
==========================================
+ Hits 33219 33224 +5
Misses 9325 9325 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a small check to the process-dumping that incoming nodes actually do have associated
NodeRepositorys (that might actually not even be necessary, probably allNodes have that by construction 🤔), and that these repositories actually do hold objects. This avoids emptynode_inputsdirectories being created when dumping.