Add more pytest fixture tests

[danielhollas]

Follow-up to #6904

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.31%. Comparing base (b235b3a) to head (98ce975).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6882      +/-   ##
==========================================
+ Coverage   79.20%   79.31%   +0.12%     
==========================================
  Files         566      566              
  Lines       43461    43461              
==========================================
+ Hits        34417    34468      +51     
+ Misses       9044     8993      -51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[danielhollas]

@agoscinski just heads up that I think this should be included in the 2.7.0 release otherwise we risk breaking people's CIs (as it broke aiidalab-widgets-base). I can work on this over the weekend to drive it home.

[agoscinski]

@danielhollas what do you think about restructuring the tests into tests/unittests and tests/fixtures, where tests/unittests contains all current tests and tests/fixtures contains all tests you include by this PR for the fixture. Then we can execute these folder separately quite conveniently in the CI without entanglement, we have all tests in the test folder. I am bit worried about tests in the src that some discovery will run these tests by accident in some setups for whatever reason. I have no good argument that this could happen but I recently had the problem that when activating a spack environment that pytest always ran in any folder the spack pytest tests. So I would like to avoid shipping tests to the user

[danielhollas]

@agoscinski I agree that we should not ship a test file as part of the package. However, splitting the test suite at the top like that seems like a very heavy-handed solution to this. Ultimately we just need to move one test file out of the src/ directory somewhere else. I'll think about it a bit more, resolve the merge conflicts here and ask for review once it is ready.

[danielhollas]

For now I've moved the test file inside the .github directory. Given that this file shouldn't really be updated often this is hopefully fine. @agoscinski feel free to take over this PR, I will not have time to work on this further in the next two weeks.

[danielhollas]

This test is already covered in tests/tools/pytest_fixtures/test_configuration.py so I removed it here.

[danielhollas]

Note that this file was basically just moved from tests/manage/tests/test_pytest_fixtures.py to tests/tools/pytest_fixtures/test_orm.py. And since the tests here work for both old and new fixtured, I've also copied the to the .github/test_legacy_pytest_fixtures.py.

[danielhollas]

@agoscinski I've merged in main so this is ready for review. The diff on Github might be a bit confusing, please see my comments.

[danielhollas]

These tests were copied here from tests/manage/tests/test_pytest_fixtures.py, they are valid for both the legacy and new fixtures.

[mbercx]

I see you've picked up I'm looking into the aiida-core test fixtures ^^. Valiant effort @danielhollas, thanks a lot. I'll try to review it this week, but have some other TODO's to check before I can get to it.