Support click 8.2 #6883
Support click 8.2 #6883
Conversation
In 8.2.0, just running 'verdi' or 'python -m aiida' without any arguments returns non-zero code. In verdi.sh we add '-h' to workaround this.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6883 +/- ##
==========================================
+ Coverage 79.16% 79.18% +0.03%
==========================================
Files 566 567 +1
Lines 43489 43521 +32
==========================================
+ Hits 34424 34459 +35
+ Misses 9065 9062 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
danielhollas
force-pushed
the
lock-update-click
branch
from
09197bc to
61466fb
Compare
danielhollas
force-pushed
the
lock-update-click
branch
2 times, most recently
from
6c1d04a to
18759ce
Compare
danielhollas
force-pushed
the
lock-update-click
branch
from
18759ce to
1b07415
Compare
|
Do you know why the test-install ci workflow did not fail until the reaese 8.2.1? I was able to merge yesterday #6880 without a problem and 8.2.0 was already released. |
That's because test-install did not run on this PR. :-) There is a nightly run of test-install that is (I am assuming) failing now, but it doesn't report anywhere so nobody noticed. Somebody should add the same Slack ping that we have for nightly tests to |
I see now that we specify path in the workflow. Thanks! I was a bit confused when fixing the RTD. |
tests/cmdline/commands/test_node.py
Outdated
| @@ -637,22 +637,22 @@ def verify_deletion(self, nodes_deleted=True, folders_deleted=True): | |||
| if nodes_deleted: | |||
| for workflow_pk in self.workflow_pks: | |||
| with pytest.raises(NotExistent): | |||
| WorkflowNode.objects.get(pk=workflow_pk) | |||
| WorkflowNode.collection.get(pk=workflow_pk) | |||
There was a problem hiding this comment.
/home/hollas/atmospec/aiida-core/tests/cmdline/commands/test_node.py:655: AiidaDeprecationWarning:
objectsproperty is deprecated, usecollectioninstead. (this will be removed in v3)
| @@ -372,7 +372,7 @@ def _perform_delete(): | |||
| from aiida.orm.utils.remote import clean_mapping_remote_paths, get_calcjob_remote_paths | |||
| from aiida.tools.graph.graph_traversers import get_nodes_delete | |||
|
|
|||
| backend = get_manager().get_backend() | |||
| backend = get_manager().get_profile_storage() | |||
There was a problem hiding this comment.
/home/hollas/atmospec/aiida-core/src/aiida/manage/manager.py:251: AiidaDeprecationWarning: get_backend() is deprecated, use get_profile_storage() instead (this will be removed in v3)
warn_deprecation('get_backend() is deprecated, use get_profile_storage() instead', version=3)
There was a problem hiding this comment.
After adjusting the stacklevel
/home/hollas/atmospec/aiida-core/src/aiida/cmdline/commands/cmd_node.py:375: AiidaDeprecationWarning: get_backend() is deprecated, use get_profile_storage() instead (this will be removed in v3)
backend = get_manager().get_backend()
There have been a huge amount of changes in 8.2.0, we might need to pin click to 8.1 until they are resolved:
https://click.palletsprojects.com/en/stable/changes/#version-8-2-0
Things that definitely affect us: