Skip to content

fix: avoid numpy truth-value ambiguity in keyword/structured search #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
msaidbilgehan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: avoid numpy truth-value ambiguity in keyword/structured search #56

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions MCP/server/database/vector_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,8 @@ async def keyword_search(
scores = []
for idx, row in df.iterrows():
score = 0
entry_keywords = set(k.lower() for k in (row["keywords"] or []))
row_keywords = row["keywords"] if row["keywords"] is not None else []
entry_keywords = set(k.lower() for k in row_keywords)
entry_text = row["lossless_restatement"].lower()

for kw in keywords:
Expand Down Expand Up @@ -267,7 +268,8 @@ async def structured_search(
if persons:
persons_lower = set(p.lower() for p in persons)
for i, row in df.iterrows():
row_persons = set(p.lower() for p in (row["persons"] or []))
persons_val = row["persons"] if row["persons"] is not None else []
row_persons = set(p.lower() for p in persons_val)
if not persons_lower.intersection(row_persons):
mask[i] = False

Expand All @@ -284,7 +286,8 @@ async def structured_search(
entities_lower = set(e.lower() for e in entities)
for i, row in df.iterrows():
if mask[i]:
row_entities = set(e.lower() for e in (row["entities"] or []))
entities_val = row["entities"] if row["entities"] is not None else []
row_entities = set(e.lower() for e in entities_val)
if not entities_lower.intersection(row_entities):
mask[i] = False

Expand Down