Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssl support #712

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

ssl support #712

wants to merge 15 commits into from

Conversation

zrvku2000
Copy link

@zrvku2000 zrvku2000 commented Jan 22, 2025

What do these changes do?

implements ssl support

Are there changes in behavior for the user?

no

Related issue number

Fixes #208

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 96.26866% with 5 lines in your changes missing coverage. Please review.

Project coverage is 95.15%. Comparing base (47680ea) to head (fd8e41b).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
aiohttp_devtools/runserver/config.py 83.33% 3 Missing and 1 partial ⚠️
aiohttp_devtools/runserver/serve.py 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #712      +/-   ##
==========================================
- Coverage   95.85%   95.15%   -0.70%     
==========================================
  Files          23       24       +1     
  Lines        1714     1818     +104     
  Branches      198      119      -79     
==========================================
+ Hits         1643     1730      +87     
- Misses         46       58      +12     
- Partials       25       30       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dreamsorcerer
Copy link
Member

Thanks, looking good. Just need to review the test failures and coverage.

@zrvku2000
Copy link
Author

zrvku2000 commented Jan 29, 2025

livereload.js doesn't check browser's 'location.protocol' property and always uses 'ws' specification for handshake. So aux server reverted to http.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Features Request: Add HTTPS Support
2 participants