Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #10332/a0e64bb4 backport][3.12] Log the remote that generates request errors #10338

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Jan 20, 2025

This is a backport of PR #10332 as merged into master (a0e64bb).

What do these changes do?

Currently we only log that a request error occurred with no information about which remote the error
came from. This made it quite difficult to find
the offending remote

Are there changes in behavior for the user?

The remote address is now found in the logs

Is it a substantial burden for the maintainers to support this?

no

Related issue number

#10331

Copy link

codspeed-hq bot commented Jan 20, 2025

CodSpeed Performance Report

Merging #10338 will not alter performance

Comparing patchback/backports/3.12/a0e64bb42b8783a83b2c80ccd899f32cb8691dc2/pr-10332 (9635687) with 3.12 (016cbae)

Summary

✅ 47 untouched benchmarks

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.08%. Comparing base (016cbae) to head (9635687).
Report is 1 commits behind head on 3.12.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.12   #10338   +/-   ##
=======================================
  Coverage   98.08%   98.08%           
=======================================
  Files         123      123           
  Lines       37237    37237           
  Branches     2111     2111           
=======================================
  Hits        36525    36525           
  Misses        543      543           
  Partials      169      169           
Flag Coverage Δ
CI-GHA 97.98% <100.00%> (ø)
OS-Linux 97.67% <100.00%> (ø)
OS-Windows 94.73% <100.00%> (-0.01%) ⬇️
OS-macOS 96.82% <100.00%> (ø)
Py-3.10.11 94.32% <100.00%> (-2.39%) ⬇️
Py-3.10.16 ?
Py-3.11.11 ?
Py-3.11.9 94.41% <100.00%> (-2.40%) ⬇️
Py-3.12.8 97.77% <100.00%> (ø)
Py-3.13.1 97.76% <100.00%> (ø)
Py-3.9.13 96.61% <100.00%> (ø)
Py-3.9.21 97.16% <100.00%> (ø)
Py-pypy7.3.16 96.75% <100.00%> (+<0.01%) ⬆️
VM-macos 96.82% <100.00%> (ø)
VM-ubuntu 97.67% <100.00%> (ø)
VM-windows 94.73% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco enabled auto-merge (squash) January 20, 2025 19:11
@bdraco bdraco disabled auto-merge January 20, 2025 20:19
@bdraco bdraco enabled auto-merge (squash) January 20, 2025 20:20
@bdraco bdraco merged commit 5a62ec9 into 3.12 Jan 20, 2025
33 checks passed
@bdraco bdraco deleted the patchback/backports/3.12/a0e64bb42b8783a83b2c80ccd899f32cb8691dc2/pr-10332 branch January 20, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant