Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #10366/3fb2c8df backport][3.11] Fix sdist make #10367

Open
wants to merge 1 commit into
base: 3.11
Choose a base branch
from

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Jan 29, 2025

This is a backport of PR #10366 as merged into master (3fb2c8d).

What do these changes do?

Three fixes related to use of source distribution to build aiohttp:

  1. Add missing tools directory to sdist, as it is required by the Makefile targets.
  2. Fix tools/gen.py to work outside a git checkout, by looking for pyproject.toml rather than .git.
  3. Add a cythonize-nodeps target that can be used by downstream packagers to perform cythonization without calling pip.

Are there changes in behavior for the user?

This fixes the ability to call make when working in an unpacked source distribution (currently it would fail due to missing tools/gen.py).

Is it a substantial burden for the maintainers to support this?

Don't think so. Worst case, the extra Makefile rule would go out of sync.

Related issue number

n/a

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
  • Add a new news fragment into the CHANGES/ folder

(cherry picked from commit 3fb2c8d)
@patchback patchback bot requested review from webknjaz and asvetlov as code owners January 29, 2025 15:56
@patchback patchback bot mentioned this pull request Jan 29, 2025
5 tasks
Copy link

codspeed-hq bot commented Jan 29, 2025

CodSpeed Performance Report

Merging #10367 will improve performances by 10.68%

Comparing patchback/backports/3.11/3fb2c8dfcc8f52089cb48a1136d3e569d1ac73ff/pr-10366 (e481a57) with 3.11 (ac895b8)

Summary

⚡ 1 improvements
✅ 46 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
test_one_hundred_get_requests_with_512kib_chunked_payload[pyloop] 233.9 ms 211.3 ms +10.68%

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.06%. Comparing base (ac895b8) to head (e481a57).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             3.11   #10367      +/-   ##
==========================================
- Coverage   98.07%   98.06%   -0.01%     
==========================================
  Files         123      123              
  Lines       37228    37228              
  Branches     4477     4477              
==========================================
- Hits        36510    36507       -3     
- Misses        540      543       +3     
  Partials      178      178              
Flag Coverage Δ
CI-GHA 97.95% <ø> (-0.01%) ⬇️
OS-Linux 97.65% <ø> (-0.01%) ⬇️
OS-Windows 94.69% <ø> (ø)
OS-macOS 96.78% <ø> (-0.01%) ⬇️
Py-3.10.11 96.63% <ø> (ø)
Py-3.10.16 97.20% <ø> (-0.01%) ⬇️
Py-3.11.11 97.28% <ø> (+0.03%) ⬆️
Py-3.11.9 96.72% <ø> (+0.01%) ⬆️
Py-3.12.8 97.72% <ø> (+0.03%) ⬆️
Py-3.13.1 97.71% <ø> (ø)
Py-3.9.13 96.56% <ø> (ø)
Py-3.9.21 97.12% <ø> (ø)
Py-pypy7.3.16 96.70% <ø> (+<0.01%) ⬆️
VM-macos 96.78% <ø> (-0.01%) ⬇️
VM-ubuntu 97.65% <ø> (-0.01%) ⬇️
VM-windows 94.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant