[PR #10569/dfbf782b backport][3.11] Break cyclic references when there is an exception handling a request #10571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
…#10569) <!-- Thank you for your contribution! --> ## What do these changes do? This is a partial fix for #10548 - There is still another case for `SystemRoute`s that needs to be addressed. No reproducer available yet. - There is also another case on the client side on connection refused that still needs to be addressed #10548 (comment) ## Are there changes in behavior for the user? fixes memory leak ## Is it a substantial burden for the maintainers to support this? no (cherry picked from commit dfbf782)
CodSpeed Performance ReportMerging #10571 will not alter performanceComparing Summary
|
bdraco
approved these changes
Mar 16, 2025
1 task
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## 3.11 #10571 +/- ##
=======================================
Coverage 98.09% 98.09%
=======================================
Files 125 126 +1
Lines 37454 37486 +32
Branches 4517 4522 +5
=======================================
+ Hits 36740 36772 +32
Misses 538 538
Partials 176 176
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bdraco
deleted the
patchback/backports/3.11/dfbf782ba4ea3eabfe052e6224727cf83efdffb5/pr-10569
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #10569 as merged into master (dfbf782).
What do these changes do?
fixes #10548
Are there changes in behavior for the user?
fixes a potential memory leak
Is it a substantial burden for the maintainers to support this?
no