Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parametrize leak tests #10577

Merged
merged 1 commit into from
Mar 16, 2025
Merged

Parametrize leak tests #10577

merged 1 commit into from
Mar 16, 2025

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Mar 16, 2025

Small cleanup to the leak tests
#10569 (comment)

@bdraco bdraco requested a review from asvetlov as a code owner March 16, 2025 22:38
@bdraco bdraco added bot:chronographer:skip This PR does not need to include a change note backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot labels Mar 16, 2025
@bdraco bdraco mentioned this pull request Mar 16, 2025
Merged
@bdraco bdraco added the backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot label Mar 16, 2025
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Mar 16, 2025

CodSpeed Performance Report

Merging #10577 will not alter performance

Comparing parametrize_leak_tests (1c91808) with master (a59e74b)

Summary

✅ 47 untouched benchmarks

@bdraco bdraco enabled auto-merge (squash) March 16, 2025 23:07
@codecov Codecov
Copy link

codecov bot commented Mar 16, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.70%. Comparing base (a59e74b) to head (1c91808).
Report is 2 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #10577      +/-   ##
==========================================
+ Coverage   98.68%   98.70%   +0.01%     
==========================================
  Files         125      125              
  Lines       37367    37363       -4     
  Branches     2063     2063              
==========================================
+ Hits        36875    36878       +3     
+ Misses        342      338       -4     
+ Partials      150      147       -3
Flag Coverage Δ
CI-GHA 98.58% <100.00%> (+0.01%) ⬆️
OS-Linux 98.25% <100.00%> (+0.01%) ⬆️
OS-Windows 96.19% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.36% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 97.27% <100.00%> (-0.01%) ⬇️
Py-3.10.16 97.82% <100.00%> (+0.68%) ⬆️
Py-3.11.11 97.90% <100.00%> (-0.01%) ⬇️
Py-3.11.9 97.36% <100.00%> (+<0.01%) ⬆️
Py-3.12.9 98.35% <100.00%> (-0.01%) ⬇️
Py-3.13.2 98.34% <100.00%> (+0.70%) ⬆️
Py-3.9.13 97.16% <100.00%> (+<0.01%) ⬆️
Py-3.9.21 97.69% <100.00%> (-0.01%) ⬇️
Py-pypy7.3.16 94.10% <50.00%> (?)
VM-macos 97.36% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 98.25% <100.00%> (+0.01%) ⬆️
VM-windows 96.19% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit 3c60cd2 into master Mar 16, 2025
43 checks passed
@bdraco bdraco deleted the parametrize_leak_tests branch March 16, 2025 23:23
@patchback Patchback
Copy link
Contributor

patchback bot commented Mar 16, 2025 •
edited
Loading

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/3c60cd220a8a393e5ab7cff1d39087ca77639166/pr-10577

Backported as #10580

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Mar 16, 2025
@bdraco @patchback
Parametrize leak tests (#10577)
19985a0 
Small cleanup to the leak tests
#10569 (comment)

(cherry picked from commit 3c60cd2)
@patchback patchback bot mentioned this pull request Mar 16, 2025
Merged
@patchback Patchback
Copy link
Contributor

patchback bot commented Mar 16, 2025 •
edited
Loading

Backport to 3.12: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.12/3c60cd220a8a393e5ab7cff1d39087ca77639166/pr-10577

Backported as #10581

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Mar 16, 2025
@bdraco @patchback
Parametrize leak tests (#10577)
73ce123 
Small cleanup to the leak tests
#10569 (comment)

(cherry picked from commit 3c60cd2)
@patchback patchback bot mentioned this pull request Mar 16, 2025
Merged
bdraco added a commit that referenced this pull request Mar 16, 2025
@patchback @bdraco
[PR #10577/3c60cd22 backport][3.12] Parametrize leak tests (#10581)
c6fedfa 
**This is a backport of PR #10577 as merged into master
(3c60cd2).**



Small cleanup to the leak tests
#10569 (comment)

Co-authored-by: J. Nick Koston <[email protected]>
bdraco added a commit that referenced this pull request Mar 17, 2025
@patchback @bdraco
[PR #10577/3c60cd22 backport][3.11] Parametrize leak tests (#10580)
d40e227 
**This is a backport of PR #10577 as merged into master
(3c60cd2).**



Small cleanup to the leak tests
#10569 (comment)

Co-authored-by: J. Nick Koston <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bdraco