[PR #10542/e1d2d77c backport][3.12] only use AI_ADDRCONFIG when supported by getaddrinfo
#10579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
The fallback implementation for getaddrinfo in CPython doesn't support `AI_ADDRCONFIG` and currently fails with a bad flags error. This changes the implementation to only set the flag if it's part of `AI_MASK`. Since `AI_MASK` isn't necessarily available either this has to be checked first. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: J. Nick Koston <[email protected]> (cherry picked from commit e1d2d77)
bdraco
approved these changes
Mar 16, 2025
CodSpeed Performance ReportMerging #10579 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## 3.12 #10579 +/- ##
==========================================
+ Coverage 98.06% 98.08% +0.01%
==========================================
Files 126 126
Lines 37527 37535 +8
Branches 2122 2121 -1
==========================================
+ Hits 36802 36817 +15
+ Misses 552 548 -4
+ Partials 173 170 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bdraco
deleted the
patchback/backports/3.12/e1d2d77cc678e81f7ab7dc687edf8dd7add3ef0b/pr-10542
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #10542 as merged into master (e1d2d77).
The fallback implementation for getaddrinfo in CPython doesn't support
AI_ADDRCONFIGand currently fails with a bad flags error. This changes the implementation to only set the flag if it's part ofAI_MASK. SinceAI_MASKisn't necessarily available either this has to be checked first.