-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip test_autobahn if python_on_whales is missing #10597
Conversation
CodSpeed Performance ReportMerging #10597 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10597 +/- ##
==========================================
- Coverage 98.71% 98.70% -0.01%
==========================================
Files 125 125
Lines 37366 37368 +2
Branches 2064 2064
==========================================
- Hits 36884 36883 -1
- Misses 335 338 +3
Partials 147 147
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
codecov has dropped. Maybe the current tests don't have python-on-whales installed? |
Definitely appears to be in the requirements file, so not sure if that change is working correctly. |
Is there anything which should be done on my side? |
Well, the PR needs to work correctly. i.e. The tests still need to run in our CI. |
Docker (and therefore python_on_whales) is not portable and would be missing on e.g. BSD systems. Don't fail tests in that case.
I think I've figured it out. |
Backport to 3.12: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 01b2a86 on top of patchback/backports/3.12/01b2a86a6f9e768b24ca3c6f880defe8b895af65/pr-10597 Backporting merged PR #10597 into master
🤖 @patchback |
If you could handle the backport as per the instructions above, that'd be great. |
(cherry picked from commit 01b2a86)
See #10614. Does it make sense to also backport it to 3.11? |
What do these changes do?
Docker (and therefore python_on_whales) is not portable and would be missing on e.g. BSD systems.
Instead of failing if python_on_whales cannot be imported, just skip tests which require it.
Are there changes in behavior for the user?
Not really, unless they run tests on BSD, in which case tests should no longer fail.
Is it a substantial burden for the maintainers to support this?
Not really.
Related issue number
Checklist
CONTRIBUTORS.txt
CHANGES/
foldername it
<issue_or_pr_num>.<type>.rst
(e.g.588.bugfix.rst
)if you don't have an issue number, change it to the pull request
number after creating the PR
.bugfix
: A bug fix for something the maintainers deemed animproper undesired behavior that got corrected to match
pre-agreed expectations.
.feature
: A new behavior, public APIs. That sort of stuff..deprecation
: A declaration of future API removals and breakingchanges in behavior.
.breaking
: When something public is removed in a breaking way.Could be deprecated in an earlier release.
.doc
: Notable updates to the documentation structure or buildprocess.
.packaging
: Notes for downstreams about unobvious side effectsand tooling. Changes in the test invocation considerations and
runtime assumptions.
.contrib
: Stuff that affects the contributor experience. e.g.Running tests, building the docs, setting up the development
environment.
.misc
: Changes that are hard to assign to any of the abovecategories.
Make sure to use full sentences with correct case and punctuation,
for example:
Use the past tense or the present tense a non-imperative mood,
referring to what's changed compared to the last released version
of this project.