Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "requests" to "aiohttp" in docs #10602

Merged
merged 1 commit into from
Mar 20, 2025

Conversation

SmartHypercube
Copy link
Contributor

What do these changes do?

Replace "requests" to "aiohttp" in docs.

(I have checked that there are no other similar problems in the docs. This is the only one.)

Are there changes in behavior for the user?

No.

Is it a substantial burden for the maintainers to support this?

Au contraire! I believe this pull request removes a substantial burden for the maintainers since they no longer have to keep an eye on how requests supports URL parameters :)

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES/ folder (is this really necessary for this change?)
    • name it <issue_or_pr_num>.<type>.rst (e.g. 588.bugfix.rst)

    • if you don't have an issue number, change it to the pull request
      number after creating the PR

      • .bugfix: A bug fix for something the maintainers deemed an
        improper undesired behavior that got corrected to match
        pre-agreed expectations.
      • .feature: A new behavior, public APIs. That sort of stuff.
      • .deprecation: A declaration of future API removals and breaking
        changes in behavior.
      • .breaking: When something public is removed in a breaking way.
        Could be deprecated in an earlier release.
      • .doc: Notable updates to the documentation structure or build
        process.
      • .packaging: Notes for downstreams about unobvious side effects
        and tooling. Changes in the test invocation considerations and
        runtime assumptions.
      • .contrib: Stuff that affects the contributor experience. e.g.
        Running tests, building the docs, setting up the development
        environment.
      • .misc: Changes that are hard to assign to any of the above
        categories.
    • Make sure to use full sentences with correct case and punctuation,
      for example:

      Fixed issue with non-ascii contents in doctest text files
      -- by :user:`contributor-gh-handle`.

      Use the past tense or the present tense a non-imperative mood,
      referring to what's changed compared to the last released version
      of this project.

Copy link

codspeed-hq bot commented Mar 20, 2025

CodSpeed Performance Report

Merging #10602 will not alter performance

Comparing SmartHypercube-fork:master (c93f69e) with master (1b96586)

Summary

✅ 47 untouched benchmarks

Copy link

codecov bot commented Mar 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.71%. Comparing base (4f45448) to head (c93f69e).
Report is 6 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10602   +/-   ##
=======================================
  Coverage   98.71%   98.71%           
=======================================
  Files         125      125           
  Lines       37366    37366           
  Branches     2064     2064           
=======================================
  Hits        36884    36884           
  Misses        335      335           
  Partials      147      147           
Flag Coverage Δ
CI-GHA 98.58% <ø> (ø)
OS-Linux 98.25% <ø> (ø)
OS-Windows 96.18% <ø> (-0.01%) ⬇️
OS-macOS 97.36% <ø> (ø)
Py-3.10.11 97.27% <ø> (-0.01%) ⬇️
Py-3.10.16 97.81% <ø> (-0.01%) ⬇️
Py-3.11.11 97.90% <ø> (+<0.01%) ⬆️
Py-3.11.9 97.35% <ø> (ø)
Py-3.12.9 98.35% <ø> (ø)
Py-3.13.2 98.35% <ø> (+<0.01%) ⬆️
Py-3.9.13 97.15% <ø> (ø)
Py-3.9.21 97.69% <ø> (+0.04%) ⬆️
Py-pypy7.3.16 78.33% <ø> (-15.20%) ⬇️
VM-macos 97.36% <ø> (ø)
VM-ubuntu 98.25% <ø> (ø)
VM-windows 96.18% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dreamsorcerer Dreamsorcerer added backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot bot:chronographer:skip This PR does not need to include a change note labels Mar 20, 2025
@Dreamsorcerer Dreamsorcerer merged commit b6f34d4 into aio-libs:master Mar 20, 2025
42 of 43 checks passed
Copy link
Contributor

patchback bot commented Mar 20, 2025

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/b6f34d4b27ffc45c138bdba428f6e1a5cf9367e4/pr-10602

Backported as #10612

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Mar 20, 2025
Copy link
Contributor

patchback bot commented Mar 20, 2025

Backport to 3.12: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.12/b6f34d4b27ffc45c138bdba428f6e1a5cf9367e4/pr-10602

Backported as #10613

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Mar 20, 2025
Dreamsorcerer pushed a commit that referenced this pull request Mar 20, 2025
…n docs (#10613)

**This is a backport of PR #10602 as merged into master
(b6f34d4).**

Co-authored-by: Hypercube <[email protected]>
Dreamsorcerer pushed a commit that referenced this pull request Mar 20, 2025
…n docs (#10612)

**This is a backport of PR #10602 as merged into master
(b6f34d4).**

Co-authored-by: Hypercube <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants