-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace "requests" to "aiohttp" in docs #10602
Conversation
CodSpeed Performance ReportMerging #10602 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #10602 +/- ##
=======================================
Coverage 98.71% 98.71%
=======================================
Files 125 125
Lines 37366 37366
Branches 2064 2064
=======================================
Hits 36884 36884
Misses 335 335
Partials 147 147
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Backport to 3.11: 💚 backport PR created✅ Backport PR branch: Backported as #10612 🤖 @patchback |
(cherry picked from commit b6f34d4)
Backport to 3.12: 💚 backport PR created✅ Backport PR branch: Backported as #10613 🤖 @patchback |
(cherry picked from commit b6f34d4)
…n docs (#10613) **This is a backport of PR #10602 as merged into master (b6f34d4).** Co-authored-by: Hypercube <[email protected]>
…n docs (#10612) **This is a backport of PR #10602 as merged into master (b6f34d4).** Co-authored-by: Hypercube <[email protected]>
What do these changes do?
Replace "requests" to "aiohttp" in docs.
(I have checked that there are no other similar problems in the docs. This is the only one.)
Are there changes in behavior for the user?
No.
Is it a substantial burden for the maintainers to support this?
Au contraire! I believe this pull request removes a substantial burden for the maintainers since they no longer have to keep an eye on how
requests
supports URL parameters :)Related issue number
Checklist
CONTRIBUTORS.txt
CHANGES/
folder (is this really necessary for this change?)name it
<issue_or_pr_num>.<type>.rst
(e.g.588.bugfix.rst
)if you don't have an issue number, change it to the pull request
number after creating the PR
.bugfix
: A bug fix for something the maintainers deemed animproper undesired behavior that got corrected to match
pre-agreed expectations.
.feature
: A new behavior, public APIs. That sort of stuff..deprecation
: A declaration of future API removals and breakingchanges in behavior.
.breaking
: When something public is removed in a breaking way.Could be deprecated in an earlier release.
.doc
: Notable updates to the documentation structure or buildprocess.
.packaging
: Notes for downstreams about unobvious side effectsand tooling. Changes in the test invocation considerations and
runtime assumptions.
.contrib
: Stuff that affects the contributor experience. e.g.Running tests, building the docs, setting up the development
environment.
.misc
: Changes that are hard to assign to any of the abovecategories.
Make sure to use full sentences with correct case and punctuation,
for example:
Use the past tense or the present tense a non-imperative mood,
referring to what's changed compared to the last released version
of this project.