Skip to content

Re-backport 10713 - add regression test #11807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dreamsorcerer merged 2 commits into from
Dec 7, 2025
+2 −2
Merged

Re-backport 10713 - add regression test #11807

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1ff3d1
Re-backport: Avoid fetching loop time on each request unless logging …
bdraco Apr 18, 2025
5ea3264
Regression test no longer expected to fail
Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES/10713.misc.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Optimized web server performance when access logging is disabled by reducing time syscalls -- by :user:`bdraco`.
2 changes: 1 addition & 1 deletion aiohttp/web_protocol.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,7 +457,7 @@ def force_close(self) -> None:
def log_access(
self, request: BaseRequest, response: StreamResponse, time: float | None
) -> None:
if self.access_logger is not None and self.access_logger.enabled:
if self._logging_enabled and self.access_logger is not None:
if TYPE_CHECKING:
assert time is not None
self.access_logger.log(request, response, self._loop.time() - time)
Expand Down
1 change: 0 additions & 1 deletion tests/test_web_log.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,6 @@ def log(
assert "This should not be logged" not in caplog.text


@pytest.mark.xfail(reason="#11778")
async def test_logger_does_not_log_when_enabled_post_init(
aiohttp_server: AiohttpServer,
aiohttp_client: AiohttpClient,
Expand Down
Loading