Fix quoted cookie #5398

Dreamsorcerer · 2021-01-11T22:12:21Z

Fixes #5397

asvetlov · 2021-11-01T10:58:04Z

Looks like a draft, converting

Dreamsorcerer · 2021-11-01T18:05:01Z

Yes, but I also don't see how to fix this, without breaking another of the test cases:
#5397 (comment)

…fix-quoted-cookie

codecov · 2024-09-09T22:25:50Z

❌ 1 Tests Failed:

Tests completed	Failed	Passed	Skipped
3294	1	3293	24

View the top 1 failed tests by shortest run time

tests.test_cookiejar test_quotes_correctly_based_on_input[pyloop-pre-quoted cookie]

Stack Traces | 0.032s run time

loop = &lt;_UnixSelectorEventLoop running=False closed=False debug=False&gt;
cookies = 'foo="quoted_value"', expected = 'Cookie: foo="quoted_value"'
quote_bool = True

    #x1B[0m#x1B[37m@pytest#x1B[39;49;00m.mark.parametrize(#x1B[90m#x1B[39;49;00m
        (#x1B[33m"#x1B[39;49;00m#x1B[33mcookies#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m, #x1B[33m"#x1B[39;49;00m#x1B[33mexpected#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m, #x1B[33m"#x1B[39;49;00m#x1B[33mquote_bool#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m),#x1B[90m#x1B[39;49;00m
        [#x1B[90m#x1B[39;49;00m
            (#x1B[90m#x1B[39;49;00m
                #x1B[33m"#x1B[39;49;00m#x1B[33mshared-cookie=first; ip-cookie=second; Domain=127.0.0.1;#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m,#x1B[90m#x1B[39;49;00m
                #x1B[33m"#x1B[39;49;00m#x1B[33mCookie: ip-cookie=second#x1B[39;49;00m#x1B[33m\r#x1B[39;49;00m#x1B[33m\n#x1B[39;49;00m#x1B[33mCookie: shared-cookie=first#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m,#x1B[90m#x1B[39;49;00m
                #x1B[94mTrue#x1B[39;49;00m,#x1B[90m#x1B[39;49;00m
            ),#x1B[90m#x1B[39;49;00m
            (#x1B[33m'#x1B[39;49;00m#x1B[33mip-cookie=#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m#x1B[33msecond#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m#x1B[33m; Domain=127.0.0.1;#x1B[39;49;00m#x1B[33m'#x1B[39;49;00m, #x1B[33m'#x1B[39;49;00m#x1B[33mCookie: ip-cookie=#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m#x1B[33msecond#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m#x1B[33m'#x1B[39;49;00m, #x1B[94mTrue#x1B[39;49;00m),#x1B[90m#x1B[39;49;00m
            (#x1B[33m"#x1B[39;49;00m#x1B[33mcustom-cookie=value/one;#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m, #x1B[33m'#x1B[39;49;00m#x1B[33mCookie: custom-cookie=#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m#x1B[33mvalue/one#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m#x1B[33m'#x1B[39;49;00m, #x1B[94mTrue#x1B[39;49;00m),#x1B[90m#x1B[39;49;00m
            (#x1B[33m"#x1B[39;49;00m#x1B[33mcustom-cookie=value1;#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m, #x1B[33m"#x1B[39;49;00m#x1B[33mCookie: custom-cookie=value1#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m, #x1B[94mTrue#x1B[39;49;00m),#x1B[90m#x1B[39;49;00m
            (#x1B[33m"#x1B[39;49;00m#x1B[33mcustom-cookie=value/one;#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m, #x1B[33m"#x1B[39;49;00m#x1B[33mCookie: custom-cookie=value/one#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m, #x1B[94mFalse#x1B[39;49;00m),#x1B[90m#x1B[39;49;00m
            (#x1B[33m'#x1B[39;49;00m#x1B[33mfoo=#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m#x1B[33mquoted_value#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m#x1B[33m'#x1B[39;49;00m, #x1B[33m'#x1B[39;49;00m#x1B[33mCookie: foo=#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m#x1B[33mquoted_value#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m#x1B[33m'#x1B[39;49;00m, #x1B[94mTrue#x1B[39;49;00m),#x1B[90m#x1B[39;49;00m
            (#x1B[33m'#x1B[39;49;00m#x1B[33mfoo=#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m#x1B[33mquoted_value#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m#x1B[33m; domain=127.0.0.1#x1B[39;49;00m#x1B[33m'#x1B[39;49;00m, #x1B[33m'#x1B[39;49;00m#x1B[33mCookie: foo=#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m#x1B[33mquoted_value#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m#x1B[33m'#x1B[39;49;00m, #x1B[94mTrue#x1B[39;49;00m),#x1B[90m#x1B[39;49;00m
        ],#x1B[90m#x1B[39;49;00m
        ids=(#x1B[90m#x1B[39;49;00m
            #x1B[33m"#x1B[39;49;00m#x1B[33mIP domain preserved#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m,#x1B[90m#x1B[39;49;00m
            #x1B[33m"#x1B[39;49;00m#x1B[33mno shared cookie#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m,#x1B[90m#x1B[39;49;00m
            #x1B[33m"#x1B[39;49;00m#x1B[33mquoted cookie with special char#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m,#x1B[90m#x1B[39;49;00m
            #x1B[33m"#x1B[39;49;00m#x1B[33mquoted cookie w/o special char#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m,#x1B[90m#x1B[39;49;00m
            #x1B[33m"#x1B[39;49;00m#x1B[33munquoted cookie with special char#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m,#x1B[90m#x1B[39;49;00m
            #x1B[33m"#x1B[39;49;00m#x1B[33mpre-quoted cookie#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m,#x1B[90m#x1B[39;49;00m
            #x1B[33m"#x1B[39;49;00m#x1B[33mpre-quoted cookie with domain#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m,#x1B[90m#x1B[39;49;00m
        ),#x1B[90m#x1B[39;49;00m
    )#x1B[90m#x1B[39;49;00m
    #x1B[94masync#x1B[39;49;00m #x1B[94mdef#x1B[39;49;00m #x1B[92mtest_quotes_correctly_based_on_input#x1B[39;49;00m(#x1B[90m#x1B[39;49;00m
        loop: asyncio.AbstractEventLoop, cookies: #x1B[96mstr#x1B[39;49;00m, expected: #x1B[96mstr#x1B[39;49;00m, quote_bool: #x1B[96mbool#x1B[39;49;00m#x1B[90m#x1B[39;49;00m
    ) -&gt; #x1B[94mNone#x1B[39;49;00m:#x1B[90m#x1B[39;49;00m
        jar = CookieJar(unsafe=#x1B[94mTrue#x1B[39;49;00m, quote_cookie=quote_bool)#x1B[90m#x1B[39;49;00m
        jar.update_cookies(SimpleCookie(cookies))#x1B[90m#x1B[39;49;00m
        cookies_sent = jar.filter_cookies(URL(#x1B[33m"#x1B[39;49;00m#x1B[33mhttp://127.0.0.1/#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m)).output(header=#x1B[33m"#x1B[39;49;00m#x1B[33mCookie:#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m)#x1B[90m#x1B[39;49;00m
&gt;       #x1B[94massert#x1B[39;49;00m cookies_sent == expected#x1B[90m#x1B[39;49;00m
#x1B[1m#x1B[31mE       assert 'Cookie: foo=quoted_value' == 'Cookie: foo="quoted_value"'#x1B[0m
#x1B[1m#x1B[31mE         #x1B[0m
#x1B[1m#x1B[31mE         - Cookie: foo="quoted_value"#x1B[0m
#x1B[1m#x1B[31mE         ?             -            -#x1B[0m
#x1B[1m#x1B[31mE         + Cookie: foo=quoted_value#x1B[0m

cookies    = 'foo="quoted_value"'
cookies_sent = 'Cookie: foo=quoted_value'
expected   = 'Cookie: foo="quoted_value"'
jar        = &lt;aiohttp.cookiejar.CookieJar object at 0x107860c10&gt;
loop       = &lt;_UnixSelectorEventLoop running=False closed=False debug=False&gt;
quote_bool = True

#x1B[1m#x1B[31mtests/test_cookiejar.py#x1B[0m:407: AssertionError

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

Dreamsorcerer · 2024-09-09T22:46:20Z

I'm giving up on this one. I think at some point we should probably drop http.cookies, as it seems to give too many issues. We should also lose the interpretation of quoted cookies altogether as this concept doesn't exist in either latest or oldest cookie spec and was never adopted by browsers.

Dreamsorcerer requested review from asvetlov and webknjaz as code owners January 11, 2021 22:12

psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jan 11, 2021

Test for pre-quoted cookies.

296b421

Dreamsorcerer force-pushed the fix-quoted-cookie branch from 3f0e7df to 296b421 Compare January 11, 2021 22:15

Dreamsorcerer added the backport-3.8 label Jan 11, 2021

Add change file.

bf7516d

asvetlov marked this pull request as draft November 1, 2021 10:58

webknjaz added the backport-3.9 label Sep 20, 2022

Dreamsorcerer added 2 commits September 20, 2022 14:54

Test for pre-quoted cookies.

1fe0020

Add change file.

9c7a1ad

webknjaz force-pushed the fix-quoted-cookie branch from bf7516d to 9c7a1ad Compare September 20, 2022 12:54

webknjaz removed the backport-3.8 label Sep 20, 2022

webknjaz added the backport-3.10 label Jan 28, 2024

bdraco removed the backport-3.9 label Jul 31, 2024

Dreamsorcerer removed the backport-3.10 label Aug 24, 2024

Dreamsorcerer added 2 commits September 9, 2024 23:12

Merge branch 'master' into fix-quoted-cookie

4385485

Merge branch 'fix-quoted-cookie' of github.com:aio-libs/aiohttp into …

285685c

…fix-quoted-cookie

Dreamsorcerer closed this Sep 9, 2024

Dreamsorcerer deleted the fix-quoted-cookie branch September 9, 2024 22:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix quoted cookie #5398

Fix quoted cookie #5398

Dreamsorcerer commented Jan 11, 2021 •

edited

Loading

asvetlov commented Nov 1, 2021

Dreamsorcerer commented Nov 1, 2021

codecov bot commented Sep 9, 2024

Dreamsorcerer commented Sep 9, 2024

Fix quoted cookie #5398

Fix quoted cookie #5398

Conversation

Dreamsorcerer commented Jan 11, 2021 • edited Loading

asvetlov commented Nov 1, 2021

Dreamsorcerer commented Nov 1, 2021

codecov bot commented Sep 9, 2024

❌ 1 Tests Failed:

Dreamsorcerer commented Sep 9, 2024

Dreamsorcerer commented Jan 11, 2021 •

edited

Loading