Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get() actually issues "gets" command on the wire #111

Closed
sapphirecat opened this issue Nov 20, 2018 · 3 comments · Fixed by #310
Closed

get() actually issues "gets" command on the wire #111

sapphirecat opened this issue Nov 20, 2018 · 3 comments · Fixed by #310

Comments

@sapphirecat
Copy link

This appears to be because _multi_get() defaults with_cas=True but the callers are all written as if the default were with_cas=False.
@Dreamsorcerer
Copy link
Member

@thehesiod Any chance you want to investigate this?

@Dreamsorcerer Dreamsorcerer mentioned this issue Dec 5, 2022
Merged
@thehesiod
Copy link
Contributor

one line fix,

aiomcache/aiomcache/client.py

Line 149 in ca3e79e

values, _ = yield from self._multi_get(conn, key)
should pass with_case=False. I'd actually remove the default too

@jayzfbn
Copy link
Contributor

jayzfbn commented Dec 5, 2022

@thehesiod asked me to submit a PR for this; I can do that shortly

@jayzfbn jayzfbn mentioned this issue Dec 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

set with_cas to false for single get jayzfbn/aiomcache
4 participants
@sapphirecat @Dreamsorcerer @thehesiod @jayzfbn