-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add flag support #92
add flag support #92
Conversation
Codecov Report
@@ Coverage Diff @@
## master #92 +/- ##
========================================
+ Coverage 91.5% 92.3% +0.8%
========================================
Files 5 6 +1
Lines 259 286 +27
Branches 38 44 +6
========================================
+ Hits 237 264 +27
Misses 11 11
Partials 11 11
Continue to review full report at Codecov.
|
btw another option is adding a client wrapper what will do the right thing |
I'm not so familiar with these flags. But, would you still be interested in updating the PR to get this merged? |
rebasing now |
# Conflicts: # .travis.yml # CHANGES.rst # Makefile # aiomcache/__init__.py # aiomcache/client.py # requirements.txt # tests/commands_test.py # tests/conftest.py
attempt to fix socket warnings in test, remove direct pylibmc dependency
This pull request introduces 1 alert when merging 65686d3 into 56d1377 - view on LGTM.com new alerts:
|
Got a PR for that? |
| Got a PR for that? It's in this PR. I'm off today but I'll sit down and take another spin at this on Monday and try to address the remaining comments. |
Right, I missed the first set of commits. Weird that the failing test is not the one that got updated (or even the before the failing test)... |
address comments, additional tests and examples
I think my last commit should address the open comments. I also added some tests just for my own sanity. |
This pull request introduces 1 alert when merging 6d24183 into 2aac5e5 - view on LGTM.com new alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. It looks like GitHub code scanning with CodeQL is already set up for this repo, so no further action is needed 🚀. For more information, please check out our post on the GitHub blog. |
This pull request introduces 1 alert when merging c04c6d2 into cc2a55a - view on LGTM.com new alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. It looks like GitHub code scanning with CodeQL is already set up for this repo, so no further action is needed 🚀. For more information, please check out our post on the GitHub blog. |
This pull request introduces 1 alert when merging 36cb848 into cc2a55a - view on LGTM.com new alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. It looks like GitHub code scanning with CodeQL is already set up for this repo, so no further action is needed 🚀. For more information, please check out our post on the GitHub blog. |
Thanks for that, finally got through it all. |
Thanks a bunch for the merge; no urgency on any of this but is a release version rev on the radar any time soon? Totally fine waiting a bit if one is coming sometime soon anyway, just thought I would check. Thx! |
Yep, I'll do it this week. Was hoping someone might verify and fix #111 before I did a release. |
No rush; thanks a bunch! |
Will try a release on Sunday. |
adds Client arg for method to decode values which have flags