Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transition from Travis CI to GitHub Actions #235

Merged
merged 35 commits into from
Jan 11, 2022
Merged

Transition from Travis CI to GitHub Actions #235

merged 35 commits into from
Jan 11, 2022

Conversation

jkeys089
Copy link
Contributor

@jkeys089 jkeys089 commented Jan 10, 2022 •
edited
Loading

What do these changes do?

  1. Bring this branch up to date with the main branch.
  2. Transition from Travis CI to GitHub Actions.
  3. Fix test_version test that was not working on python 3.8+

Are there changes in behavior for the user?

No

Related issue number

#137 and #196

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Add a new news fragment into the CHANGES folder
    • name it 235.misc

dependabot-preview bot and others added 30 commits April 27, 2020 08:33
@dependabot-preview
Bump pytest-sugar from 0.9.2 to 0.9.3
0e43fc1 
Bumps [pytest-sugar](https://github.com/Teemu/pytest-sugar) from 0.9.2 to 0.9.3.
- [Release notes](https://github.com/Teemu/pytest-sugar/releases)
- [Changelog](https://github.com/Teemu/pytest-sugar/blob/master/CHANGES.rst)
- [Commits](https://github.com/Teemu/pytest-sugar/commits)

Signed-off-by: dependabot-preview[bot] <[email protected]>
@dependabot-preview
Bump flake8 from 3.7.9 to 3.8.1
f995584 
Bumps [flake8](https://gitlab.com/pycqa/flake8) from 3.7.9 to 3.8.1.
- [Release notes](https://gitlab.com/pycqa/flake8/tags)
- [Commits](https://gitlab.com/pycqa/flake8/compare/3.7.9...3.8.1)

Signed-off-by: dependabot-preview[bot] <[email protected]>
@dependabot-preview
Bump flake8 from 3.8.1 to 3.8.2
4ae97e7 
Bumps [flake8](https://gitlab.com/pycqa/flake8) from 3.8.1 to 3.8.2.
- [Release notes](https://gitlab.com/pycqa/flake8/tags)
- [Commits](https://gitlab.com/pycqa/flake8/compare/3.8.1...3.8.2)

Signed-off-by: dependabot-preview[bot] <[email protected]>
@dependabot-preview
Bump flake8 from 3.8.2 to 3.8.3
d3a4500 
Bumps [flake8](https://gitlab.com/pycqa/flake8) from 3.8.2 to 3.8.3.
- [Release notes](https://gitlab.com/pycqa/flake8/tags)
- [Commits](https://gitlab.com/pycqa/flake8/compare/3.8.2...3.8.3)

Signed-off-by: dependabot-preview[bot] <[email protected]>
@dependabot-preview
Bump pytest-sugar from 0.9.3 to 0.9.4
0f527db 
Bumps [pytest-sugar](https://github.com/Teemu/pytest-sugar) from 0.9.3 to 0.9.4.
- [Release notes](https://github.com/Teemu/pytest-sugar/releases)
- [Changelog](https://github.com/Teemu/pytest-sugar/blob/master/CHANGES.rst)
- [Commits](https://github.com/Teemu/pytest-sugar/commits)

Signed-off-by: dependabot-preview[bot] <[email protected]>
@dependabot-preview
Bump flake8 from 3.8.3 to 3.8.4
4cc7c8c 
Bumps [flake8](https://gitlab.com/pycqa/flake8) from 3.8.3 to 3.8.4.
- [Release notes](https://gitlab.com/pycqa/flake8/tags)
- [Commits](https://gitlab.com/pycqa/flake8/compare/3.8.3...3.8.4)

Signed-off-by: dependabot-preview[bot] <[email protected]>
@asvetlov
Add Apache 2 licences (#210)
6d0d86d 
Committed via https://github.com/asottile/all-repos
@dependabot-preview
Bump pygments from 2.3.1 to 2.7.3 (#211)
f178299 
Bumps [pygments](https://github.com/pygments/pygments) from 2.3.1 to 2.7.3.
- [Release notes](https://github.com/pygments/pygments/releases)
- [Changelog](https://github.com/pygments/pygments/blob/master/CHANGES)
- [Commits](pygments/pygments@2.3.1...2.7.3)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
@dependabot-preview
Bump docutils from 0.15.2 to 0.16 (#175)
bafe0ea 
Bumps [docutils](http://docutils.sourceforge.net/) from 0.15.2 to 0.16.

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
@dependabot-preview
Bump pytest from 4.0.2 to 6.1.2 (#206)
69f6333 
Bumps [pytest](https://github.com/pytest-dev/pytest) from 4.0.2 to 6.1.2.
- [Release notes](https://github.com/pytest-dev/pytest/releases)
- [Changelog](https://github.com/pytest-dev/pytest/blob/master/CHANGELOG.rst)
- [Commits](pytest-dev/pytest@4.0.2...6.1.2)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
@dependabot-preview
Bump pytest from 6.1.2 to 6.2.0 (#212)
5d45772
@dependabot-preview
Bump pytest from 6.2.0 to 6.2.1 (#213)
4b2327b
@dependabot-preview
Bump pygments from 2.7.3 to 2.7.4 (#215)
cb29be7
@dependabot-preview
Bump pytest from 6.2.1 to 6.2.2 (#216)
96bfe3a
@dependabot-preview
Bump pygments from 2.7.4 to 2.8.0 (#217)
248cbf2
@dependabot-preview
Bump pygments from 2.8.0 to 2.8.1 (#218)
9583ce4
@dependabot-preview
Bump flake8 from 3.8.4 to 3.9.0 (#219)
9143db1
@dependabot-preview
Bump docutils from 0.16 to 0.17 (#220)
3b2eee9
@dependabot-preview
Bump pytest from 6.2.2 to 6.2.3 (#221)
febeb08
@dependabot-preview
Bump flake8 from 3.9.0 to 3.9.1 (#222)
272f549
@dependabot-preview
Bump docutils from 0.17 to 0.17.1 (#223)
a4345d7
@dependabot-preview
Bump pygments from 2.8.1 to 2.9.0 (#225)
c113640
@dependabot-preview
Bump pytest from 6.2.3 to 6.2.4 (#226)
4016d99
@dependabot-preview
Bump flake8 from 3.9.1 to 3.9.2 (#227)
10c0ad1
@dependabot-preview
Upgrade to GitHub-native Dependabot (#224)
a037b10 
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
@asvetlov
Update CHANGES
78dfe22
@dependabot
Bump flake8 from 3.9.2 to 4.0.1 (#234)
85e854e 
Bumps [flake8](https://github.com/pycqa/flake8) from 3.9.2 to 4.0.1.
- [Release notes](https://github.com/pycqa/flake8/releases)
- [Commits](PyCQA/flake8@3.9.2...4.0.1)

---
updated-dependencies:
- dependency-name: flake8
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump docutils from 0.17.1 to 0.18 (#233)
e8b2aaf 
Bumps [docutils](http://docutils.sourceforge.net/) from 0.17.1 to 0.18.

---
updated-dependencies:
- dependency-name: docutils
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump pytest from 6.2.4 to 6.2.5 (#232)
bc31223 
Bumps [pytest](https://github.com/pytest-dev/pytest) from 6.2.4 to 6.2.5.
- [Release notes](https://github.com/pytest-dev/pytest/releases)
- [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst)
- [Commits](pytest-dev/pytest@6.2.4...6.2.5)

---
updated-dependencies:
- dependency-name: pytest
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@asvetlov
Cleanup requirements
d733564
dependabot bot and others added 3 commits November 11, 2021 10:31
@dependabot
Bump pytest-cov from 2.8.1 to 3.0.0 (#230)
85125e9 
Bumps [pytest-cov](https://github.com/pytest-dev/pytest-cov) from 2.8.1 to 3.0.0.
- [Release notes](https://github.com/pytest-dev/pytest-cov/releases)
- [Changelog](https://github.com/pytest-dev/pytest-cov/blob/master/CHANGELOG.rst)
- [Commits](pytest-dev/pytest-cov@v2.8.1...v3.0.0)

---
updated-dependencies:
- dependency-name: pytest-cov
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@jkeys089
Merge branch 'master' into py37
f1d3525
@jkeys089
transition from Travis CI to GitHub actions
095cfa8
@jkeys089 jkeys089 mentioned this pull request Jan 10, 2022
Merged
@jkeys089
Copy link
Contributor Author

Two quick notes:

  1. You'll likely want to create your own memcached action. I forked niden/actions-memcached just to be able to run the matrix strategy without failing after the first job.
  2. I'm not 100% sure the deploy phase is correct. Per @Dreamsorcerer I mostly just copied this from aiohttp-session

Dreamsorcerer
Dreamsorcerer reviewed Jan 10, 2022
View reviewed changes
.github/workflows/ci.yaml Outdated
name: Deploy
environment: release
if: github.event_name == 'push' && contains(github.ref, 'refs/tags/')
needs: [test]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, seems aiohttp-session is not as recent as I thought. Can you add the check step as seen in this one: https://github.com/aio-libs/aiohttp-devtools/blob/master/.github/workflows/ci.yml#L104

We'll also need the lint step added, but we can do that in another PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Dreamsorcerer
Dreamsorcerer reviewed Jan 10, 2022
View reviewed changes
.github/workflows/ci.yaml

deploy:
name: Deploy
environment: release
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@webknjaz Can you setup the release environment please?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asvetlov I've found another PyPI package where I'm not added as an owner.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dreamsorcerer done

webknjaz
webknjaz reviewed Jan 11, 2022
View reviewed changes
@Dreamsorcerer
Copy link
Member

I'll merge this so we can get started on this.

@webknjaz Any thoughts on the memcached action?

1. You'll likely want to create your own [memcached action](https://github.com/jkeys089/actions-memcached). I forked [niden/actions-memcached](https://github.com/niden/actions-memcached) just to be able to run the matrix strategy without failing after the first job.

@Dreamsorcerer Dreamsorcerer merged commit 4766028 into aio-libs:py37 Jan 11, 2022
Dreamsorcerer added a commit that referenced this pull request Jan 11, 2022
@Dreamsorcerer
Revert "Transition from Travis CI to GitHub Actions (#235)"
fe8e841 
This reverts commit 4766028.
@Dreamsorcerer
Copy link
Member

I just realised the target was py37. Could you resubmit one for master? Best to keep individual merges small. Thanks.

@webknjaz
Copy link
Member

@Dreamsorcerer not sure, I guess it depends on how you'd want to use that action.

@jkeys089
Copy link
Contributor Author

jkeys089 commented Jan 11, 2022 •
edited
Loading

@Dreamsorcerer not sure, I guess it depends on how you'd want to use that action.

@Dreamsorcerer @webknjaz I'm happy to leave it up. I just assumed you'd want to have it under your aio-libs project.

@jkeys089
Copy link
Contributor Author

I just realised the target was py37. Could you resubmit one for master? Best to keep individual merges small. Thanks.

@Dreamsorcerer I spent some time on this today but I wasn't able to get the current master branch to pass tests on a version of python that still runs on ubuntu-latest. I could try to get things running on an older image / python version but I just want to be practical. Please LMK your thoughts.

@Dreamsorcerer
Copy link
Member

OK, I'll go through it in a couple of days and maybe just use the py37 branch then.

Dreamsorcerer added a commit that referenced this pull request Jan 12, 2022
@asvetlov @Dreamsorcerer
@rexzhang @jkeys089 @dependabot-preview @dependabot
Support Python 3.7+ (#164)
534e9bf 
* Run on Python 3.7, drop 3.4

* Drop yield from syntax

* Fix flake

* Fix syntax error

* Fix conftest

* Fix conftest

* Work on

* Fix (#207)


Co-authored-by: Rex Zhang <[email protected]>

* Transition from Travis CI to GitHub Actions (#235)

* Bump pytest-sugar from 0.9.2 to 0.9.3

Bumps [pytest-sugar](https://github.com/Teemu/pytest-sugar) from 0.9.2 to 0.9.3.
- [Release notes](https://github.com/Teemu/pytest-sugar/releases)
- [Changelog](https://github.com/Teemu/pytest-sugar/blob/master/CHANGES.rst)
- [Commits](https://github.com/Teemu/pytest-sugar/commits)

Signed-off-by: dependabot-preview[bot] <[email protected]>

* Bump flake8 from 3.7.9 to 3.8.1

Bumps [flake8](https://gitlab.com/pycqa/flake8) from 3.7.9 to 3.8.1.
- [Release notes](https://gitlab.com/pycqa/flake8/tags)
- [Commits](https://gitlab.com/pycqa/flake8/compare/3.7.9...3.8.1)

Signed-off-by: dependabot-preview[bot] <[email protected]>

* Bump flake8 from 3.8.1 to 3.8.2

Bumps [flake8](https://gitlab.com/pycqa/flake8) from 3.8.1 to 3.8.2.
- [Release notes](https://gitlab.com/pycqa/flake8/tags)
- [Commits](https://gitlab.com/pycqa/flake8/compare/3.8.1...3.8.2)

Signed-off-by: dependabot-preview[bot] <[email protected]>

* Bump flake8 from 3.8.2 to 3.8.3

Bumps [flake8](https://gitlab.com/pycqa/flake8) from 3.8.2 to 3.8.3.
- [Release notes](https://gitlab.com/pycqa/flake8/tags)
- [Commits](https://gitlab.com/pycqa/flake8/compare/3.8.2...3.8.3)

Signed-off-by: dependabot-preview[bot] <[email protected]>

* Bump pytest-sugar from 0.9.3 to 0.9.4

Bumps [pytest-sugar](https://github.com/Teemu/pytest-sugar) from 0.9.3 to 0.9.4.
- [Release notes](https://github.com/Teemu/pytest-sugar/releases)
- [Changelog](https://github.com/Teemu/pytest-sugar/blob/master/CHANGES.rst)
- [Commits](https://github.com/Teemu/pytest-sugar/commits)

Signed-off-by: dependabot-preview[bot] <[email protected]>

* Bump flake8 from 3.8.3 to 3.8.4

Bumps [flake8](https://gitlab.com/pycqa/flake8) from 3.8.3 to 3.8.4.
- [Release notes](https://gitlab.com/pycqa/flake8/tags)
- [Commits](https://gitlab.com/pycqa/flake8/compare/3.8.3...3.8.4)

Signed-off-by: dependabot-preview[bot] <[email protected]>

* Add Apache 2 licences (#210)

Committed via https://github.com/asottile/all-repos

* Bump pygments from 2.3.1 to 2.7.3 (#211)

Bumps [pygments](https://github.com/pygments/pygments) from 2.3.1 to 2.7.3.
- [Release notes](https://github.com/pygments/pygments/releases)
- [Changelog](https://github.com/pygments/pygments/blob/master/CHANGES)
- [Commits](pygments/pygments@2.3.1...2.7.3)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

* Bump docutils from 0.15.2 to 0.16 (#175)

Bumps [docutils](http://docutils.sourceforge.net/) from 0.15.2 to 0.16.

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

* Bump pytest from 4.0.2 to 6.1.2 (#206)

Bumps [pytest](https://github.com/pytest-dev/pytest) from 4.0.2 to 6.1.2.
- [Release notes](https://github.com/pytest-dev/pytest/releases)
- [Changelog](https://github.com/pytest-dev/pytest/blob/master/CHANGELOG.rst)
- [Commits](pytest-dev/pytest@4.0.2...6.1.2)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

* Bump pytest from 6.1.2 to 6.2.0 (#212)

* Bump pytest from 6.2.0 to 6.2.1 (#213)

* Bump pygments from 2.7.3 to 2.7.4 (#215)

* Bump pytest from 6.2.1 to 6.2.2 (#216)

* Bump pygments from 2.7.4 to 2.8.0 (#217)

* Bump pygments from 2.8.0 to 2.8.1 (#218)

* Bump flake8 from 3.8.4 to 3.9.0 (#219)

* Bump docutils from 0.16 to 0.17 (#220)

* Bump pytest from 6.2.2 to 6.2.3 (#221)

* Bump flake8 from 3.9.0 to 3.9.1 (#222)

* Bump docutils from 0.17 to 0.17.1 (#223)

* Bump pygments from 2.8.1 to 2.9.0 (#225)

* Bump pytest from 6.2.3 to 6.2.4 (#226)

* Bump flake8 from 3.9.1 to 3.9.2 (#227)

* Upgrade to GitHub-native Dependabot (#224)

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

* Update CHANGES

* Bump flake8 from 3.9.2 to 4.0.1 (#234)

Bumps [flake8](https://github.com/pycqa/flake8) from 3.9.2 to 4.0.1.
- [Release notes](https://github.com/pycqa/flake8/releases)
- [Commits](PyCQA/flake8@3.9.2...4.0.1)

---
updated-dependencies:
- dependency-name: flake8
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump docutils from 0.17.1 to 0.18 (#233)

Bumps [docutils](http://docutils.sourceforge.net/) from 0.17.1 to 0.18.

---
updated-dependencies:
- dependency-name: docutils
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump pytest from 6.2.4 to 6.2.5 (#232)

Bumps [pytest](https://github.com/pytest-dev/pytest) from 6.2.4 to 6.2.5.
- [Release notes](https://github.com/pytest-dev/pytest/releases)
- [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst)
- [Commits](pytest-dev/pytest@6.2.4...6.2.5)

---
updated-dependencies:
- dependency-name: pytest
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Cleanup requirements

* Bump pytest-cov from 2.8.1 to 3.0.0 (#230)

Bumps [pytest-cov](https://github.com/pytest-dev/pytest-cov) from 2.8.1 to 3.0.0.
- [Release notes](https://github.com/pytest-dev/pytest-cov/releases)
- [Changelog](https://github.com/pytest-dev/pytest-cov/blob/master/CHANGELOG.rst)
- [Commits](pytest-dev/pytest-cov@v2.8.1...v3.0.0)

---
updated-dependencies:
- dependency-name: pytest-cov
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* transition from Travis CI to GitHub actions

* add `check` step ti CI action

* use latest codecov action

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Andrew Svetlov <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jon Keys <[email protected]>

* Remove max-parallel.

* Tweak

Co-authored-by: Sam Bull <[email protected]>
Co-authored-by: Rex Zhang <[email protected]>
Co-authored-by: jkeys089 <[email protected]>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jon Keys <[email protected]>
Co-authored-by: Sam Bull <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webknjaz webknjaz webknjaz left review comments

@Dreamsorcerer Dreamsorcerer Dreamsorcerer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jkeys089 @Dreamsorcerer @webknjaz @asvetlov