Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved to match line breaks using regular expressions in search box. #3724

Closed
wants to merge 2 commits into from
Closed

Improved to match line breaks using regular expressions in search box. #3724

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jul 27, 2018

Issue #, if available:
#2869

Description of changes:
Fixed because search of line breaks by regular expression was not working correctly via search box.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Mahiro Komura added 2 commits July 28, 2018 00:04
Improved to match line breaks using regular expressions in search box.
Improved to match line breaks using regular expressions in search box.
@nightwing
Copy link
Member

This is not quite right, because splitting the regex this way has high chance of breaking it.
Perhaps we need multiline flag, to search the whole string

@akoreman
Copy link
Contributor

This functionality has been implemented by #5675, closing this PR.

@akoreman akoreman closed this Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants