Skip to content

Resolves #1: Refactor Search Results Component #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Resolves #1: Refactor Search Results Component #1

wants to merge 6 commits into from

Conversation

@ajtw7
Copy link
Owner

@ajtw7 ajtw7 commented Feb 5, 2024 •
edited
Loading

This pull request addresses the issue described in #2 .

Changes proposed in this PR:

  • remove useEffect and useState and place GET call for all results in its own file
  • import reactQuery into the component for more efficient fetching and query mgmt
  • memorization
  • pagination
  • image fallback

@ajtw7 ajtw7 added duplicate This issue or pull request already exists enhancement New feature or request labels Feb 5, 2024
@ajtw7 ajtw7 self-assigned this Feb 5, 2024
@netlify
Copy link

netlify bot commented Feb 5, 2024 •
edited
Loading

✅ Deploy Preview for chipper-semolina-25921b ready!

Name Link
🔨 Latest commit ddc4ac8
🔍 Latest deploy log https://app.netlify.com/sites/chipper-semolina-25921b/deploys/672ae62e8959590008c02850
😎 Deploy Preview https://deploy-preview-1--chipper-semolina-25921b.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ajtw7 added 5 commits February 5, 2024 23:33
@ajtw7
moved searchResults GET into seperate file; imported results call via…
1493062 
… useInfiniteQuery hook w/ pagination and conditional rendoring. Results limited to six atm; implemented 'load more' btn below results; 'prev' btn currently nonfunctional.
@ajtw7
extracted searchResults GET call from component
04221a3
@ajtw7
update .gitignore
3f826e9
@ajtw7
updating .gitignore file and removing dup
1f24db0
@ajtw7
refactoring userprofilepage.js and extracting call
ddc4ac8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ajtw7 ajtw7

Labels

duplicate This issue or pull request already exists enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ajtw7