Skip to content

Conversation

baktun14
Copy link
Contributor

@baktun14 baktun14 commented Oct 7, 2025

#1918

This one is currently blocked by a few issues:

  • the blockchain being down
  • chain-sdk expiration authz issue
  • chain-sdk authz any type not loading

@baktun14 baktun14 requested a review from a team as a code owner October 7, 2025 10:29
Copy link

coderabbitai bot commented Oct 7, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch features/chain-sdk-next-api

Comment @coderabbitai help to get the list of available commands and usage tips.

"node": "22.14.0",
"npm": "^11.2.0"
}
},
Copy link
Contributor

@github-actions github-actions bot Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔄 Carefully review the package-lock.json diff

Resolve the comment if everything is ok

+ apps/api/node_modules/@akashnetwork/chain-sdk/node_modules/@cosmjs/crypto                0.33.1  
+ apps/api/node_modules/@akashnetwork/chain-sdk/node_modules/@cosmjs/encoding              0.33.1  
+ apps/api/node_modules/@akashnetwork/chain-sdk/node_modules/@cosmjs/math                  0.33.1  
+ apps/api/node_modules/@akashnetwork/chain-sdk/node_modules/@cosmjs/proto-signing         0.33.1  
+ apps/api/node_modules/@akashnetwork/chain-sdk/node_modules/@cosmjs/stargate/node_modules/@cosmjs/amino 0.33.1  
+ apps/api/node_modules/@akashnetwork/chain-sdk/node_modules/@cosmjs/stargate              0.33.1  
+ apps/api/node_modules/@akashnetwork/chain-sdk/node_modules/@cosmjs/tendermint-rpc        0.33.1  
+ apps/api/node_modules/@akashnetwork/chain-sdk/node_modules/@cosmjs/utils                 0.33.1  
+ apps/api/node_modules/@akashnetwork/chain-sdk                                            1.0.0-alpha.8
+ apps/api/node_modules/@cosmjs/json-rpc                                                   0.33.1  
+ apps/api/node_modules/@cosmjs/socket/node_modules/@cosmjs/stream                         0.33.1  
+ apps/api/node_modules/@cosmjs/socket                                                     0.33.1  
+ apps/api/node_modules/ws                                                                 7.5.10  

@baktun14 baktun14 force-pushed the features/chain-sdk-next-api branch from 58698de to fac8c66 Compare October 7, 2025 12:05
Copy link

codecov bot commented Oct 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.98%. Comparing base (b934838) to head (2281731).
⚠️ Report is 1 commits behind head on main-sdk-next.

Additional details and impacted files
@@                Coverage Diff                @@
##           main-sdk-next    #2023      +/-   ##
=================================================
- Coverage          46.11%   45.98%   -0.13%     
=================================================
  Files               1020     1020              
  Lines              28786    28688      -98     
  Branches            7531     7486      -45     
=================================================
- Hits               13274    13192      -82     
+ Misses             15138    15122      -16     
  Partials             374      374              
Flag Coverage Δ *Carryforward flag
api 82.26% <ø> (-0.04%) ⬇️ Carriedforward from 85ed373
deploy-web 24.17% <100.00%> (+<0.01%) ⬆️
log-collector 75.35% <ø> (ø)
notifications 88.16% <ø> (ø) Carriedforward from 85ed373
provider-console 81.48% <ø> (ø)
provider-proxy 85.00% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...pi/src/address/services/address/address.service.ts 69.49% <ø> (ø)
apps/api/src/bid/http-schemas/bid.schema.ts 100.00% <ø> (ø)
apps/api/src/bid/services/bid/bid.service.ts 100.00% <ø> (ø)
apps/api/src/billing/config/env.config.ts 100.00% <ø> (ø)
apps/api/src/billing/http-schemas/tx.schema.ts 100.00% <ø> (ø)
...tch-signing-client/batch-signing-client.service.ts 90.22% <ø> (-0.15%) ⬇️
...pi/src/billing/providers/type-registry.provider.ts 100.00% <ø> (ø)
.../src/billing/services/balances/balances.service.ts 96.29% <ø> (-0.32%) ⬇️
...illing/services/chain-error/chain-error.service.ts 97.95% <ø> (ø)
...ervices/financial-stats/financial-stats.service.ts 32.43% <ø> (ø)
... and 24 more

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@baktun14 baktun14 force-pushed the features/chain-sdk-next-api branch from dae9d55 to abd2f01 Compare October 9, 2025 08:05
sandbox: ["provider.europlots-sandbox.com"],
"testnet-02": [],
"testnet-7": []
testnet: []
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could probably add a specific provider from the testnet

(data.data as any)._dbId = deploymentDbId;
(data.data as any)._deploymentGroupId = deploymentGroup.id;
(data.data as unknown as { _dbId: string; _deploymentGroupId: string })._dbId = deploymentDbId;
(data.data as unknown as { _dbId: string; _deploymentGroupId: string })._deploymentGroupId = deploymentGroup.id;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this needed? the request func accepts a response type generic

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cursor decided to just fix the any type lol

deploymentId: (deployment as any)._dbId,
deploymentGroupId: (deployment as any)._deploymentGroupId,
deploymentId: (deployment as unknown as { _dbId: string })._dbId,
deploymentGroupId: (deployment as unknown as { _deploymentGroupId: string })._deploymentGroupId,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same. just update the response schema? right?

@stalniy stalniy force-pushed the features/chain-sdk-next-api branch from 7cd2c29 to b0e3928 Compare October 13, 2025 13:59
Copy link

socket-security bot commented Oct 13, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​akashnetwork/​chain-sdk@​1.0.0-alpha.87710010096100

View full report

@baktun14 baktun14 merged commit 20095b3 into main-sdk-next Oct 13, 2025
64 of 77 checks passed
@baktun14 baktun14 deleted the features/chain-sdk-next-api branch October 13, 2025 21:24
ygrishajev pushed a commit that referenced this pull request Oct 14, 2025
* refactor: migrate provider-proxy to next chain sdk (#1980)

* feat(analytics): chain sdk next indexer (#1983)

* feat(network): testnet deposit implementation

* feat(analytics): implement new handlers for indexing

* feat(analytics): add protobuf types from chain sdk for indexer

* fix(analytics): remove test throw

* feat: update chain-sdk indexer

* feat: update net package

* fix: net package testnet (#2016)

fix: net config data

* feat: implement new chain sdk types in api

* fix: replace DepositAuthorization

* fix: update http sdk + functional test envs

* fix: undo frontend code changes

* fix: balance calculation

* fix: pr fixes

* fix: gpu prices test

* fix: tests

* fix: fallback deployment tests

* fix: stripe webhook tests

* fix: balances test

* fix: api structure for leases + tests

* fix: lease fallback tests

* fix: tests

* fix: build fix

* fix: faucet json

* refactor: gets rid of akashjs and akash-api

* fix: pr fixes for tests

* fix: build

* fix: sdl

---------

Co-authored-by: Serhii Stotskyi <[email protected]>
stalniy added a commit that referenced this pull request Oct 15, 2025
* refactor: migrate provider-proxy to next chain sdk (#1980)

* feat(analytics): chain sdk next indexer (#1983)

* feat(network): testnet deposit implementation

* feat(analytics): implement new handlers for indexing

* feat(analytics): add protobuf types from chain sdk for indexer

* fix(analytics): remove test throw

* feat: update chain-sdk indexer

* feat: update net package

* fix: net package testnet (#2016)

fix: net config data

* feat: implement new chain sdk types in api

* fix: replace DepositAuthorization

* fix: update http sdk + functional test envs

* fix: undo frontend code changes

* fix: balance calculation

* fix: pr fixes

* fix: gpu prices test

* fix: tests

* fix: fallback deployment tests

* fix: stripe webhook tests

* fix: balances test

* fix: api structure for leases + tests

* fix: lease fallback tests

* fix: tests

* fix: build fix

* fix: faucet json

* refactor: gets rid of akashjs and akash-api

* fix: pr fixes for tests

* fix: build

* fix: sdl

---------

Co-authored-by: Serhii Stotskyi <[email protected]>
ygrishajev pushed a commit that referenced this pull request Oct 15, 2025
* refactor: migrate provider-proxy to next chain sdk (#1980)

* feat(analytics): chain sdk next indexer (#1983)

* feat(network): testnet deposit implementation

* feat(analytics): implement new handlers for indexing

* feat(analytics): add protobuf types from chain sdk for indexer

* fix(analytics): remove test throw

* feat: update chain-sdk indexer

* feat: update net package

* fix: net package testnet (#2016)

fix: net config data

* feat: implement new chain sdk types in api

* fix: replace DepositAuthorization

* fix: update http sdk + functional test envs

* fix: undo frontend code changes

* fix: balance calculation

* fix: pr fixes

* fix: gpu prices test

* fix: tests

* fix: fallback deployment tests

* fix: stripe webhook tests

* fix: balances test

* fix: api structure for leases + tests

* fix: lease fallback tests

* fix: tests

* fix: build fix

* fix: faucet json

* refactor: gets rid of akashjs and akash-api

* fix: pr fixes for tests

* fix: build

* fix: sdl

---------

Co-authored-by: Serhii Stotskyi <[email protected]>
stalniy added a commit that referenced this pull request Oct 15, 2025
* refactor: migrate provider-proxy to next chain sdk (#1980)

* feat(analytics): chain sdk next indexer (#1983)

* feat(network): testnet deposit implementation

* feat(analytics): implement new handlers for indexing

* feat(analytics): add protobuf types from chain sdk for indexer

* fix(analytics): remove test throw

* feat: update chain-sdk indexer

* feat: update net package

* fix: net package testnet (#2016)

fix: net config data

* feat: implement new chain sdk types in api

* fix: replace DepositAuthorization

* fix: update http sdk + functional test envs

* fix: undo frontend code changes

* fix: balance calculation

* fix: pr fixes

* fix: gpu prices test

* fix: tests

* fix: fallback deployment tests

* fix: stripe webhook tests

* fix: balances test

* fix: api structure for leases + tests

* fix: lease fallback tests

* fix: tests

* fix: build fix

* fix: faucet json

* refactor: gets rid of akashjs and akash-api

* fix: pr fixes for tests

* fix: build

* fix: sdl

---------

Co-authored-by: Serhii Stotskyi <[email protected]>
ygrishajev pushed a commit that referenced this pull request Oct 16, 2025
* refactor: migrate provider-proxy to next chain sdk (#1980)

* feat(analytics): chain sdk next indexer (#1983)

* feat(network): testnet deposit implementation

* feat(analytics): implement new handlers for indexing

* feat(analytics): add protobuf types from chain sdk for indexer

* fix(analytics): remove test throw

* feat: update chain-sdk indexer

* feat: update net package

* fix: net package testnet (#2016)

fix: net config data

* feat: implement new chain sdk types in api

* fix: replace DepositAuthorization

* fix: update http sdk + functional test envs

* fix: undo frontend code changes

* fix: balance calculation

* fix: pr fixes

* fix: gpu prices test

* fix: tests

* fix: fallback deployment tests

* fix: stripe webhook tests

* fix: balances test

* fix: api structure for leases + tests

* fix: lease fallback tests

* fix: tests

* fix: build fix

* fix: faucet json

* refactor: gets rid of akashjs and akash-api

* fix: pr fixes for tests

* fix: build

* fix: sdl

---------

Co-authored-by: Serhii Stotskyi <[email protected]>
baktun14 added a commit that referenced this pull request Oct 20, 2025
* refactor: migrate provider-proxy to next chain sdk (#1980)

* feat(analytics): chain sdk next indexer (#1983)

* feat(network): testnet deposit implementation

* feat(analytics): implement new handlers for indexing

* feat(analytics): add protobuf types from chain sdk for indexer

* fix(analytics): remove test throw

* feat: update chain-sdk indexer

* feat: update net package

* fix: net package testnet (#2016)

fix: net config data

* feat: implement new chain sdk types in api

* fix: replace DepositAuthorization

* fix: update http sdk + functional test envs

* fix: undo frontend code changes

* fix: balance calculation

* fix: pr fixes

* fix: gpu prices test

* fix: tests

* fix: fallback deployment tests

* fix: stripe webhook tests

* fix: balances test

* fix: api structure for leases + tests

* fix: lease fallback tests

* fix: tests

* fix: build fix

* fix: faucet json

* refactor: gets rid of akashjs and akash-api

* fix: pr fixes for tests

* fix: build

* fix: sdl

---------

Co-authored-by: Serhii Stotskyi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants