Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release all resources after activity is destroyed #71

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sarwataijaz
Copy link

@sarwataijaz sarwataijaz commented Apr 26, 2024

Pull Request Template

All Submissions:

  • Have you read and acknowledged our Code of Conduct?
  • Have you checked to ensure there aren't other open Pull Requests

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

  • I added the onDestroy method in the MainActivity, as when the app was running and despite the activity being destroyed, the music resources were still not released so here directly stopping it in the onDestroy method seemed sufficient.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made relevant changes to the documentation
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for your contribution, really appreciated! We will have a look and merge it if everything checks out!

@sarwataijaz sarwataijaz reopened this Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant