fix changeSlider for infinity false case #1950
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisliuchao
added a commit
to luisliuchao/react-slick
that referenced
this pull request
Dec 30, 2020
…nitialSlide is present
|
Please fix this issue soon. |
|
@VadimSvirdoff The same issue will be for "next" arrow too. Can you add a fix for this case to your pull request? |
|
please fix this issue , |
|
@akiran ready to merge |
|
we are waiting for this merge |
|
I don't think this patch will be merged as it is, as you are just commenting some code. Are you sure the code can be removed without side effects? Have you checked what the purpose of this code was? If it really can be removed, you should just remove it and not comment it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug issue #1949 .