-
Notifications
You must be signed in to change notification settings - Fork 18
Expo 53 and update to React 19 #1398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 71cf8bd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Will look into updating to ReOwn...
Tested just now, it's building properly on iOS. |
Building on Android too. Need to check for side effects on explorer, DW and MW after upgrade to React 19. Should be rather straightforward to fix. |
…rs)" This reverts commit d7e625a.
expo.useLegacyPackaging=false | ||
|
||
# Whether the app is configured to use edge-to-edge via the app config or `react-native-edge-to-edge` plugin | ||
expo.edgeToEdgeEnabled=false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is something that we will soon need to support
// TODO: Remove this when we update the dependencies | ||
// https://github.com/expo/expo/issues/36375#issuecomment-2845231862 | ||
config.resolver.unstable_enablePackageExports = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this is gonna bite us in the 🍑 at some point. It tried disabling and updating the deps one by one but I stopped at the ethereum-cryptography
one.
apps/mobile-wallet/index.ts
Outdated
import './setupErrorHandling' | ||
// Node polyfills to be removed when dependencies are updated | ||
import 'react-native-get-random-values' | ||
import 'react-native-url-polyfill/auto' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The import is still here although the dep has been removed?
(maybe fixed in a followup commit, will check).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, was removed in the expo-doctor commit, all good!
Uh oh!
There was an error while loading. Please reload this page.