Skip to content

Conversation

mvaivre
Copy link
Member

@mvaivre mvaivre commented Jun 24, 2025

  • test that scrollbars look good on Windows

Copy link

changeset-bot bot commented Jun 24, 2025

🦋 Changeset detected

Latest commit: 71cf8bd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
alephium-desktop-wallet Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mvaivre
Copy link
Member Author

mvaivre commented Jul 22, 2025

Tested just now, it's building properly on iOS.

@mvaivre
Copy link
Member Author

mvaivre commented Jul 22, 2025

Building on Android too. Need to check for side effects on explorer, DW and MW after upgrade to React 19. Should be rather straightforward to fix.

@mvaivre mvaivre changed the title Expo 53 Expo 53 and update to React 19 Jul 22, 2025
@nop33 nop33 marked this pull request as ready for review September 30, 2025 07:22
expo.useLegacyPackaging=false

# Whether the app is configured to use edge-to-edge via the app config or `react-native-edge-to-edge` plugin
expo.edgeToEdgeEnabled=false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is something that we will soon need to support

Comment on lines +30 to +32
// TODO: Remove this when we update the dependencies
// https://github.com/expo/expo/issues/36375#issuecomment-2845231862
config.resolver.unstable_enablePackageExports = false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is gonna bite us in the 🍑 at some point. It tried disabling and updating the deps one by one but I stopped at the ethereum-cryptography one.

import './setupErrorHandling'
// Node polyfills to be removed when dependencies are updated
import 'react-native-get-random-values'
import 'react-native-url-polyfill/auto'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import is still here although the dep has been removed?
(maybe fixed in a followup commit, will check).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, was removed in the expo-doctor commit, all good!

@nop33 nop33 merged commit 65bfcc1 into master Oct 7, 2025
11 checks passed
@nop33 nop33 deleted the expo-53 branch October 7, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants