feat(side): Add Commands for Manual Width Resizing #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dirvish-side window is created with a fixed width (\`window-size-fixed\`), which prevents users from adjusting its size manually using standard window commands. This can be inconvenient when needing a temporarily wider or narrower view. This commit introduces two new interactive commands: - \`dirvish-side-increase-width\`: Enlarges the side window. - \`dirvish-side-decrease-width\`: Shrinks the side window. These commands work by temporarily overriding the \`window-size-fixed\` property during the resize operation using \`let ((window-size-fixed nil))\`. A new custom variable, \`dirvish-side-width-increment\` (default: 5), controls the amount by which the width is changed with each command. The commands and the variable are marked with \`;;;###autoload\`. Error handling for shrinking below minimum width is included.
|
Thanks for the PR! How about using the prefix argument to specify the increment value, similar to how EDIT: Besides, it seems that these 2 commands should not be autoload as they are not useful before |
The `dirvish-side-increase-width` and `dirvish-side-decrease-width` commands now accept a numeric prefix argument to control the resize amount. If no prefix argument is given, the value of `dirvish-side-width-increment` is used.
|
Hi, thanks for the feedback. I think that is a smarter way to go about it. I have committed these changes. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the inability to manually resize the
dirvish-sidewindow (#332) due to itswindow-size-fixedproperty. It introduces dedicated interactive commands that allow users to increase or decrease the side window's width on demand without permanently changing thedirvish-side-widthsetting or disrupting the fixed-size behavior during automatic window management.