Skip to content

Domain grouping for pdfs#95

Open
gshokanov wants to merge 4 commits intoalexweininger:masterfrom
gshokanov:domain-grouping-for-pdfs
Open

Domain grouping for pdfs#95
gshokanov wants to merge 4 commits intoalexweininger:masterfrom
gshokanov:domain-grouping-for-pdfs

Conversation

@gshokanov
Copy link
Copy Markdown

@gshokanov gshokanov commented Oct 14, 2019

Adds functionality for #82.
Added domain grouping for online PDF files. To test:

  • Navigate to options page.
  • Select `Group by domain' for how files are grouped.
  • Visit online tab.
  • Click on any folder to show its' contents.
    Please review and let me know what you think.

@alexweininger
Copy link
Copy Markdown
Owner

@dborg291 Since this was long ago and there have been lots of changes since the PR was created, maybe you could go through the code and see how it was implemented and adapt it for the current codebase.

Thanks!

Copy link
Copy Markdown
Owner

@alexweininger alexweininger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be updated for current codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants