Skip to content

Fix circular dependency when creating DirectionRate with auto_rate #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
m1ndg8mer wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix circular dependency when creating DirectionRate with auto_rate #95

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion app/models/gera/exchange_rate.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,13 @@ class ExchangeRate < ApplicationRecord
validates :commission, numericality: { greater_than_or_equal_to: MIN_COMISSION }
validates :calculator_type, inclusion: { in: CALCULATOR_TYPES }, allow_nil: true, if: -> { self.class.column_names.include?('calculator_type') }

delegate :rate, :currency_rate, to: :direction_rate
delegate :rate, to: :direction_rate

# Get currency_rate directly from repository to avoid circular dependency
# when creating DirectionRate (direction_rate -> exchange_rate.currency_rate -> direction_rate)
def currency_rate
@currency_rate ||= Universe.currency_rates_repository.find_currency_rate_by_pair(currency_pair)
Copy link
Copy Markdown

@dapi dapi Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ой это н правильно )

Copy link
Copy Markdown

@dapi dapi Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

так может выдутая совершенной другой currency_rate. было все верно. В чем именно проблема-то?

end

delegate :auto_comission_by_reserve, :comission_by_base_rate, :auto_rate_by_base_from,
:auto_rate_by_base_to, :auto_rate_by_reserve_from, :auto_rate_by_reserve_to,
Expand Down
Loading