第2回課題提出 #121
Open
第2回課題提出 #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanashima
requested changes
Jul 2, 2022
src/spear.c
Outdated
| scanf("%d", &A[i]); | ||
| if (ub < A[i]) | ||
| { | ||
| ub = A[i]; |
| return 0; | ||
| } | ||
|
|
||
| bool p(int x) |
There was a problem hiding this comment.
原因までは特定してませんが，多くのケースで正しく動いてないです．
もう一度確認してみてください．
There was a problem hiding this comment.
了解いたしました。
また、出力の方も了解です。
修正の期限の方は何時迄でしょうか？
There was a problem hiding this comment.
すぐに書き表せるものとしては
n=k=10
でa_iの値が全て1などですね．(追記：ケースを小さいものに修正しました)
後はでたらめなケースのほとんどでかなり大きめの値を出力しています．
There was a problem hiding this comment.
修正期限ですが，ちゃんとした日時は未定ですが，
例年では最終課題の締め切りと同じくらいです．
なので，他の課題も考慮しつつ計画的にやっていただければ大丈夫です．
nanashima
reviewed
Jul 16, 2022
| return 0; | ||
| } | ||
|
|
||
| bool p(int x) |
src/works.c
Outdated
| temp -= A[i]; | ||
| // printf("roop1(temp=%d,i=%d,count=%d)\n", temp, i, count); | ||
| ++i; | ||
| if (temp < A[i] || i >= n) |
There was a problem hiding this comment.
ここを同時に処理しているのは怪しい気がします．
temp < A[i]のときは確かに良いのですが
i>=nの時も次の(外側のwhile)ループが続きcount足されてしまうので．
あとtemp<A[i]の条件式で配列外参照するのも怖いので，同じ式を書くなら
i >= n || temp < A[i] と書いた方が良いとも思います(i>=nのとき後半実行されない)
|
ご指摘いただけた部分を修正しました |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
課題を提出します。
ご確認のほど、よろしくお願いいたします。