Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

finish #127

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

finish #127

wants to merge 7 commits into from

Conversation

TakumiHirose11
Copy link

No description provided.

nanashima
nanashima requested changes Jul 2, 2022
View reviewed changes
Copy link

@nanashima nanashima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

array.c apple.c spear.c が正しく動いていません．

src/apple.c Show resolved Hide resolved
src/array.c Outdated
}


lb=0;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

初期値が不適切です．

src/spear.c Outdated


lb=0;
ub=1000000000;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

初期値が不適切です．

@TakumiHirose11
Copy link
Author

修正しました。

nanashima
nanashima requested changes Jul 16, 2022
View reviewed changes
Copy link

@nanashima nanashima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

基礎課題が全て正しい答えを返していないです．
（ざっくり見て気付けた点のみコメントしました．）

src/array.c


lb=-1;
ub=n+1;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

初期値が不適切です．

src/apple.c
for (int t=0;t<n;t++){
res+=(A[t]+x-1)/x;
}
return res;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここはなにか真偽値を返すべきなのでは？

src/spear.c
}


lb=-1;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lbの初期値が改善できます．(number_of_spearでゼロ割が起こります．)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nanashima nanashima nanashima requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TakumiHirose11 @nanashima