Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

提出 #154

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

提出 #154

wants to merge 1 commit into from

Conversation

aokidegozaru
Copy link

No description provided.

nanashima
nanashima requested changes Jul 2, 2022
View reviewed changes
Copy link

@nanashima nanashima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

array.c apple.c spear.c が正しく動いていません．

src/array.c
for(i = 0; i < n; i++){
scanf("%d", &A[i]);
}


lb = 0;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

初期値が不適切です．

src/apple.c
lb = 0;
ub = 0;
for(i = 0; i < n ;i++){
ub = ub + A[i];
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

初期値が大きすぎて最悪桁あふれします．改善してください．

src/spear.c

lb = -1;
ub = 1;
for(i = 0; i < n; i++){
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

資料のケースでも動いてないかと思います．

src/spear.c
ub = 1;
for(i = 0; i < n; i++){
if(ub <= A[i]){
ub = A[i] + 1;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

怪しいです．

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nanashima nanashima nanashima requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aokidegozaru @nanashima