Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): make helper integration tests runnable #6562

Merged
merged 7 commits into from
Feb 17, 2025
Merged

Conversation

Haroenv
Copy link
Contributor

@Haroenv Haroenv commented Feb 17, 2025

Summary

Since a while, we haven't run the helper integration tests, and thus we haven't noticed that they don't pass on v5 anymore

Result

integration tests pass on v5 again

todo once this is passed, make sure we send the INTEGRATION_TEST_API_KEY and INTEGRATION_TEST_APPID env variables

@Haroenv Haroenv requested review from dhayab, a team and shaejaz and removed request for a team February 17, 2025 10:29
@Haroenv Haroenv force-pushed the fix/helper-remove-cb branch from 1b39d50 to 29d1a04 Compare February 17, 2025 10:31
Copy link

codesandbox-ci bot commented Feb 17, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 474235e:

Sandbox Source
example-instantsearch-getting-started Configuration
example-react-instantsearch-getting-started Configuration
example-react-instantsearch-next-app-dir-example Configuration
example-react-instantsearch-next-routing-example Configuration
example-vue-instantsearch-getting-started Configuration

Copy link
Member

@dhayab dhayab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests are failing:

FAIL test/integration-spec/helper.searchForFacetValues.js
  ● [INT][SEARCHFORFACETVALUES] Should be able to search for facet values - conjunctive

    TypeError: this.client.initIndex(...).searchForFacetValues is not a function

      413 |     searchForFacetValuesPromise = this.client
      414 |       .initIndex(state.index)
    > 415 |       .searchForFacetValues(algoliaQuery);
          |        ^
      416 |     // algoliasearch ~5.0.0
      417 |   } else {
      418 |     // @MAJOR only use client.search

      at AlgoliaSearchHelper.searchForFacetValues (src/algoliasearch.helper.js:415:8)
      at Object.<anonymous> (test/integration-spec/helper.searchForFacetValues.js:35:6)

  ● [INT][SEARCHFORFACETVALUES] Should be able to search for facet values - disjunctive

    TypeError: this.client.initIndex(...).searchForFacetValues is not a function

      413 |     searchForFacetValuesPromise = this.client
      414 |       .initIndex(state.index)
    > 415 |       .searchForFacetValues(algoliaQuery);
          |        ^
      416 |     // algoliasearch ~5.0.0
      417 |   } else {
      418 |     // @MAJOR only use client.search

      at AlgoliaSearchHelper.searchForFacetValues (src/algoliasearch.helper.js:415:8)
      at Object.<anonymous> (test/integration-spec/helper.searchForFacetValues.js:125:6)

  ● [INT][SEARCHFORFACETVALUES] Should be able to limit the number of returned items

    TypeError: this.client.initIndex(...).searchForFacetValues is not a function

      413 |     searchForFacetValuesPromise = this.client
      414 |       .initIndex(state.index)
    > 415 |       .searchForFacetValues(algoliaQuery);
          |        ^
      416 |     // algoliasearch ~5.0.0
      417 |   } else {
      418 |     // @MAJOR only use client.search

      at AlgoliaSearchHelper.searchForFacetValues (src/algoliasearch.helper.js:415:8)
      at Object.<anonymous> (test/integration-spec/helper.searchForFacetValues.js:221:17)

Seems like it's going into the search client v4 branch although I am using a v5 client. Any idea?

@Haroenv
Copy link
Contributor Author

Haroenv commented Feb 17, 2025

ah didn't think of that, it's probably because it has initIndex for the integration parts now. I'll see how that can be improved.

@Haroenv Haroenv requested a review from dhayab February 17, 2025 15:58
@Haroenv Haroenv merged commit a5f9505 into master Feb 17, 2025
14 checks passed
@Haroenv Haroenv deleted the fix/helper-remove-cb branch February 17, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants