-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): make helper integration tests runnable #6562
Conversation
1b39d50
to
29d1a04
Compare
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 474235e:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These tests are failing:
FAIL test/integration-spec/helper.searchForFacetValues.js
● [INT][SEARCHFORFACETVALUES] Should be able to search for facet values - conjunctive
TypeError: this.client.initIndex(...).searchForFacetValues is not a function
413 | searchForFacetValuesPromise = this.client
414 | .initIndex(state.index)
> 415 | .searchForFacetValues(algoliaQuery);
| ^
416 | // algoliasearch ~5.0.0
417 | } else {
418 | // @MAJOR only use client.search
at AlgoliaSearchHelper.searchForFacetValues (src/algoliasearch.helper.js:415:8)
at Object.<anonymous> (test/integration-spec/helper.searchForFacetValues.js:35:6)
● [INT][SEARCHFORFACETVALUES] Should be able to search for facet values - disjunctive
TypeError: this.client.initIndex(...).searchForFacetValues is not a function
413 | searchForFacetValuesPromise = this.client
414 | .initIndex(state.index)
> 415 | .searchForFacetValues(algoliaQuery);
| ^
416 | // algoliasearch ~5.0.0
417 | } else {
418 | // @MAJOR only use client.search
at AlgoliaSearchHelper.searchForFacetValues (src/algoliasearch.helper.js:415:8)
at Object.<anonymous> (test/integration-spec/helper.searchForFacetValues.js:125:6)
● [INT][SEARCHFORFACETVALUES] Should be able to limit the number of returned items
TypeError: this.client.initIndex(...).searchForFacetValues is not a function
413 | searchForFacetValuesPromise = this.client
414 | .initIndex(state.index)
> 415 | .searchForFacetValues(algoliaQuery);
| ^
416 | // algoliasearch ~5.0.0
417 | } else {
418 | // @MAJOR only use client.search
at AlgoliaSearchHelper.searchForFacetValues (src/algoliasearch.helper.js:415:8)
at Object.<anonymous> (test/integration-spec/helper.searchForFacetValues.js:221:17)
Seems like it's going into the search client v4 branch although I am using a v5 client. Any idea?
ah didn't think of that, it's probably because it has |
Summary
Since a while, we haven't run the helper integration tests, and thus we haven't noticed that they don't pass on v5 anymore
Result
integration tests pass on v5 again
todo once this is passed, make sure we send the
INTEGRATION_TEST_API_KEY
andINTEGRATION_TEST_APPID
env variables