Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(create-instantsearch-app): fix corejs version in vue-is template #6567

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

shaejaz
Copy link
Contributor

@shaejaz shaejaz commented Feb 17, 2025

Summary
Using the vue instantsearch template with the create-instantsearch-app results in a dependency error when running yarn start. This fixes the core-js version to prevent that.

TODO:

  • Check if other templates have the same error

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4b42421:

Sandbox Source
example-instantsearch-getting-started Configuration
example-react-instantsearch-getting-started Configuration
example-react-instantsearch-next-app-dir-example Configuration
example-react-instantsearch-next-routing-example Configuration
example-vue-instantsearch-getting-started Configuration

@shaejaz shaejaz requested review from dhayab and Haroenv February 18, 2025 12:35
@shaejaz shaejaz merged commit 018ee43 into master Feb 18, 2025
15 checks passed
@shaejaz shaejaz deleted the fix/create-is-vue-version branch February 18, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants