feat(helper): remove getRefinements, hasRefinements #6570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haroenv
requested review from
a team,
sarahdayan and
shaejaz
and removed request for
a team
Haroenv
commented
Feb 18, 2025
Comment on lines
55
to
56
| const hasRefinements = | ||
| window.search.renderState['instant_search'].clearRefinements?.canRefine; |
There was a problem hiding this comment.
normally you can directly read the renderState, but in the layout of this example, the widgets are in standalone files, and we can't import search or it would be circular.
Could be interesting in the future if templates got access to InstantSearch instance or parent.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b9e052f:
|
Haroenv
changed the title
Haroenv
force-pushed
the
next
branch
2 times, most recently
from
b1b5e4f to
32f50ac
Compare
These functions are an aggregate of multiple different functions that depend on the type of refinement you're using. It's better to use the getter for the right type of refinement. BREAKING CHANGE: remove helper.hasRefinements (use helper.state.isXXXRefined instead) BREAKING CHANGE: remove helper.getRefinements (read helper.state.XXXRefinement instead) BREAKING CHANGE: remove helper.state.getRefinements (read helper.state.XXXRefinement instead)
Haroenv
force-pushed
the
feat/remove-has-get-refinements
branch
from
d57df09 to
b9e052f
Compare
shaejaz
approved these changes
Feb 19, 2025
Haroenv
added a commit
that referenced
this pull request
Feb 19, 2025
These functions are an aggregate of multiple different functions that depend on the type of refinement you're using. It's better to use the getter for the right type of refinement. BREAKING CHANGE: remove helper.hasRefinements (use helper.state.isXXXRefined instead) BREAKING CHANGE: remove helper.getRefinements (read helper.state.XXXRefinement instead) BREAKING CHANGE: remove helper.state.getRefinements (read helper.state.XXXRefinement instead)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These functions are an aggregate of multiple different functions that depend on the type of refinement you're using. It's better to use the getter for the right type of refinement.
These functions are also not used in InstantSearch, as current refinements and clear refinements "re-implement" most of its logic to match the refinement to the right widget.
BREAKING CHANGE: remove helper.hasRefinements (use helper.state.isXXXRefined instead)
BREAKING CHANGE: remove helper.getRefinements (read helper.state.XXXRefinement instead)
BREAKING CHANGE: remove helper.state.getRefinements (read helper.state.XXXRefinement instead)
bundle size impact: -0.5kb min gz on the helper