Skip to content

Conversation

@cce
Copy link
Contributor

@cce cce commented Oct 2, 2025

Summary

This enables by default the ed25519consensus BatchVerifier implementation from #6440. It can be disabled in case of unexpected issues if necessary.

Test Plan

Existing tests should pass.

@cce cce added the Enhancement label Oct 2, 2025
@cce cce requested review from Copilot and jannotti October 6, 2025 18:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new configuration option EnableBatchVerification to control the use of ed25519 batch verification in the consensus algorithm, defaulting to enabled. This builds on work from PR #6440 by providing an option to disable the feature if issues arise.

Key changes include:

  • Added the new configuration option with default value true
  • Updated configuration version from 36 to 37
  • Integrated the batch verifier setting into the main application startup

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test/testdata/configs/config-v37.json New test configuration file with version 37 including the EnableBatchVerification option
installer/config.json.example Updated example config to version 37 with the new batch verification option
config/local_defaults.go Updated default configuration version and added EnableBatchVerification default
config/localTemplate.go Added EnableBatchVerification field definition to the Local struct
cmd/algod/main.go Added call to configure the batch verifier based on the configuration setting
Comments suppressed due to low confidence (1)

config/localTemplate.go:1

  • Corrected spelling of 'Transcations' to 'Transactions'.
// Copyright (C) 2019-2025 Algorand, Inc.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@cce cce requested a review from gmalouf October 10, 2025 14:43
@gmalouf gmalouf merged commit 21e1adf into algorand:master Oct 10, 2025
39 checks passed
@cce cce deleted the config-gobatchverifier branch October 16, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants