Skip to content

sortition: use SelectF128 - #6672

Merged
jannotti merged 8 commits into
algorand:masterfrom
cce:sortition-f128
Jul 23, 2026
Merged

sortition: use SelectF128#6672
jannotti merged 8 commits into
algorand:masterfrom
cce:sortition-f128

Conversation

@cce

@cce cce commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Summary

Once algorand/sortition#8 is merged this will pull the new version into go.mod and use the new SelectF128 method behidn a new consensus flag.

Test Plan

Beyond the tests in algorand/sortition#8 a new test TestSortitionMoneyDomain was added, and an additional error-returning check in UnauthenticatedCredential.Verify that userMoney < sortition.SelectF128MaxMoney.

@cce
cce marked this pull request as ready for review July 22, 2026 19:40
Comment thread data/committee/credential.go Outdated
@cce
cce force-pushed the sortition-f128 branch from 50012ca to cde1da4 Compare July 22, 2026 19:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 7 changed files in this pull request and generated 4 comments.

Comment thread data/committee/credential.go
Comment thread data/committee/credential.go
Comment thread data/committee/credential_test.go
Comment thread data/committee/credential_test.go
nullun
nullun previously approved these changes Jul 22, 2026
algorandskiy
algorandskiy previously approved these changes Jul 22, 2026
@algorandskiy
algorandskiy requested a review from jannotti July 22, 2026 20:21
@codecov

codecov Bot commented Jul 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.78%. Comparing base (1975415) to head (035017b).
⚠️ Report is 9 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
data/committee/credential.go 72.72% 2 Missing and 1 partial ⚠️

❗ There is a different number of reports uploaded between BASE (1975415) and HEAD (035017b). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (1975415) HEAD (035017b)
full_coverage 2 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6672       +/-   ##
===========================================
- Coverage   63.80%   47.78%   -16.02%     
===========================================
  Files         481      639      +158     
  Lines       68952    87256    +18304     
===========================================
- Hits        43992    41698     -2294     
- Misses      21350    42811    +21461     
+ Partials     3610     2747      -863     
Flag Coverage Δ
full_coverage ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@cce
cce dismissed stale reviews from algorandskiy and nullun via 835f67f July 22, 2026 23:50
@jannotti
jannotti merged commit e49103d into algorand:master Jul 23, 2026
38 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants