sortition: use SelectF128 - #6672
Merged
Merged
Conversation
cce
marked this pull request as ready for review
July 22, 2026 19:40
jannotti
reviewed
Jul 22, 2026
nullun
previously approved these changes
Jul 22, 2026
algorandskiy
previously approved these changes
Jul 22, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6672 +/- ##
===========================================
- Coverage 63.80% 47.78% -16.02%
===========================================
Files 481 639 +158
Lines 68952 87256 +18304
===========================================
- Hits 43992 41698 -2294
- Misses 21350 42811 +21461
+ Partials 3610 2747 -863
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
algorandskiy
approved these changes
Jul 23, 2026
nullun
approved these changes
Jul 23, 2026
This was referenced Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Once algorand/sortition#8 is merged this will pull the new version into go.mod and use the new
SelectF128method behidn a new consensus flag.Test Plan
Beyond the tests in algorand/sortition#8 a new test TestSortitionMoneyDomain was added, and an additional error-returning check in
UnauthenticatedCredential.VerifythatuserMoney < sortition.SelectF128MaxMoney.