Skip to content

Conversation

servantftransperfect
Copy link
Contributor

Reactivate rig support in sfmExpanding :

  • Put back the options in the node description
  • Enable post processing calibration

Rollback use of feature scale in triangulation scoring to reduce the number of outliers

Parallelize next best views estimation

A missing branch caused the bundle to be launched even if nothing new was done.

Copilot

This comment was marked as outdated.

@servantftransperfect servantftransperfect force-pushed the dev/fixExperimental branch 2 times, most recently from 6e3e001 to 9398bd7 Compare September 3, 2025 06:27
Copilot

This comment was marked as outdated.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the SfmExpanding processing pipeline by re-enabling rig support functionality and implementing performance optimizations. The changes restore previously commented-out rig constraint features and add parallelization to the next best views estimation process.

  • Reactivated rig constraint support in SfmExpanding node with post-processing calibration
  • Modified triangulation scoring to use uniform weights instead of feature scale weights
  • Added OpenMP parallelization to the expansion policy processing loop

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
main_sfmExpanding.cpp Uncommented rig constraint post-processing code to restore rig support functionality
SfmTriangulation.cpp Changed triangulation weights from feature scale-based to uniform weights
ExpansionPolicyLegacy.cpp Added OpenMP parallelization for next best views estimation processing
ExpansionChunk.cpp Added early exit condition and view counting logic to prevent unnecessary bundle adjustments
SfmExpanding.py Added rig constraint parameters to the node description interface

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@servantftransperfect servantftransperfect added this to the 3.4.0 milestone Sep 3, 2025
@CedricThebault CedricThebault merged commit 5a77873 into develop Sep 4, 2025
4 checks passed
@CedricThebault CedricThebault deleted the dev/fixExperimental branch September 4, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants