-
-
Notifications
You must be signed in to change notification settings - Fork 849
Improve SfmExpanding processing #1958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
829666c
to
2e73eeb
Compare
6e3e001
to
9398bd7
Compare
9398bd7
to
3c76807
Compare
3c76807
to
330a583
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR improves the SfmExpanding processing pipeline by re-enabling rig support functionality and implementing performance optimizations. The changes restore previously commented-out rig constraint features and add parallelization to the next best views estimation process.
- Reactivated rig constraint support in SfmExpanding node with post-processing calibration
- Modified triangulation scoring to use uniform weights instead of feature scale weights
- Added OpenMP parallelization to the expansion policy processing loop
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
main_sfmExpanding.cpp | Uncommented rig constraint post-processing code to restore rig support functionality |
SfmTriangulation.cpp | Changed triangulation weights from feature scale-based to uniform weights |
ExpansionPolicyLegacy.cpp | Added OpenMP parallelization for next best views estimation processing |
ExpansionChunk.cpp | Added early exit condition and view counting logic to prevent unnecessary bundle adjustments |
SfmExpanding.py | Added rig constraint parameters to the node description interface |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Reactivate rig support in sfmExpanding :
Rollback use of feature scale in triangulation scoring to reduce the number of outliers
Parallelize next best views estimation
A missing branch caused the bundle to be launched even if nothing new was done.