Use shape file in sphereDetection and lightingCalibration #2005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbentejac
approved these changes
Oct 13, 2025
There was a problem hiding this comment.
Working as expected! ⭐⭐⭐⭐⭐
I am not merging it straight away because it makes the "Display Lighting Circle : Sphere Detection" from the 2D Viewer useless, and since the display of the shape is now handled from the Node Editor, it should probably be removed altogether.
cbentejac
requested changes
Oct 14, 2025
There was a problem hiding this comment.
Actually there's a missing part in this PR: if the "Automatic Sphere Detection" option is disabled, the position of the sphere is supposed to be provided by the user. So we need to add a Circle attribute to replace the "Sphere Center" / "Sphere Radius" attributes, and use the position of the circle in sphereDetection.cpp to write the ouput detection.json accordingly.
The function takes a dictionary (Python-like or a flat JSON file content) represented as a flat vector of strings that contain key-value pairs into a map of pairs of strings.
cbentejac
force-pushed
the
dev/sphereDetectionWithShapeFile
branch
2 times, most recently
from
98e1b43 to
b37884d
Compare
There are now two variants of this method: - one that takes the coordinates and radius of the hand-detected spheres - one that takes a JSON file containing shape information for the spheres In both cases, `fillMissingSpheres` can be enabled to fill the location of some spheres for which the data is unavailable with the location of the last detected sphere.
cbentejac
force-pushed
the
dev/sphereDetectionWithShapeFile
branch
from
b37884d to
613a482
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR modifies the structure of the JSON file used for sphere detection.
The new format is compatible with the structure expected by Meshroom, allowing spheres to be displayed directly in the interface.
Features list
sphereDetection.lightCalibration.SphereDetectionsoftware.