[ui] Edge: Workaround on the Crash due to Edge Connections #2663
+31
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed mousePress and mouseReleased events Invoking custom Event or querying mouse buttons from the provided QMouseEvent crashes meshroom, this comes as first part of the workaround for querying when a point exists on the path
The workaround on edge crashing is to use the mouse area around the edge and query if the click exists in the edge to accept pressed or released signal
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #2663 +/- ##
========================================
Coverage 69.95% 69.95%
========================================
Files 122 122
Lines 7106 7106
========================================
Hits 4971 4971
Misses 2135 2135 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a crash issue by working around the issue of querying buttons for the MouseEvent.
MouseEvent::button() or MouseEvent::buttons() on the
mousePressEventor in theCustom MouseEventwas causing crashes some times when an event provided has issues.While the underlying issues at this point are not clear, it is evident that the crash is happening due to the PySide binding.
A similar implementation was tested on the C++ side which seems to be working fine.
Features list
[X] Workaround for edge crashing by implementing a Mouse Area which checks the pressed point to exist on the edge before emitting a pressed/released event.
Implementation remarks