Skip to content

Component structure #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 5, 2018
Merged

Component structure #4

merged 5 commits into from
Oct 5, 2018

Conversation

alivenotions
Copy link
Owner

No description provided.

@alivenotions alivenotions added the software design Any suggestion related to the design of the app label Aug 5, 2018
@alivenotions alivenotions added this to the Release 0.1 milestone Aug 5, 2018
@alivenotions alivenotions requested a review from gbhavalkar August 5, 2018 09:24
@alivenotions
Copy link
Owner Author

@gbhavalkar The build is breaking because of the following relevant error:
Failed to minify the code from this file:
./node_modules/rss-parser/lib/parser.js:16

Read this rbren/rss-parser#53 to try and resolve

gbhavalkar
gbhavalkar approved these changes Oct 5, 2018
View reviewed changes
Copy link
Collaborator

@gbhavalkar gbhavalkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing needs to be done after feature completion

@gbhavalkar gbhavalkar merged commit 9239b36 into master Oct 5, 2018
@alivenotions alivenotions deleted the component-structure branch October 7, 2018 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbhavalkar gbhavalkar gbhavalkar approved these changes

Assignees

@gbhavalkar gbhavalkar

Labels
software design Any suggestion related to the design of the app
Projects
None yet
Milestone
Release 0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@alivenotions @gbhavalkar