Open
Conversation
alja
commented
Jun 30, 2025
alja
commented
Jun 30, 2025
Owner
Author
Owner
Author
TestCheck cache control values with curl -I option from originGet the file in cache with proxy forwardingCheck saved cache-control attributes as file system xattr in the cinfo file |
osschar
reviewed
Jul 9, 2025
Collaborator
osschar
left a comment
There was a problem hiding this comment.
First pass, I was also remembering things as I went so maybe some comments are silly.
|
|
||
|
|
||
| //------------------------------------------------------------------------------ | ||
| //! Perform an fcntl() operation (defaults to passthrough). |
Collaborator
There was a problem hiding this comment.
this documentation needs to be changed, it is mostly copy of Fstat.
i'm not sure if saying that it defaults to passthrough makes sense ... we need to see if there will be some Fcntl calls that need to be handled by the cache / open-file / IO.
src/XrdPfc/XrdPfc.cc
Outdated
| XrdCl::QueryCode::Code queryCode = XrdCl::QueryCode::XAttr; | ||
| XrdCl::Buffer queryArgs(5); | ||
| std::string qs = std::to_string(queryCode); | ||
| queryArgs.FromString(qs); |
Collaborator
There was a problem hiding this comment.
why does it have to go to-string and then from-string? it's internal XrdCl enum/int.
…ibutes when file does not exist in cache yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code adds cache-control check using File::Fctnl and FileSystem::Query.
The change is related to pelican-client code PelicanPlatform/xrdcl-pelican#59