fix: guard zero native price in oracle and bridge, order wormhole send checks#29
Open
mooncitydev wants to merge 1 commit into
Open
Conversation
…d checks Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses two issues:
Gas oracle / Bridge: When the native token USD price is unset (zero), code that divides by this price could hit division-by-zero. The changes add guards so we do not perform those calculations with a zero denominator.
WormholeMessenger: The duplicate-message check is ordered before the external call (aligned with the Messenger pattern), so we fail fast on duplicates without invoking the bridge contract unnecessarily.
Tests: gas-oracle.test.ts is updated to cover the new behavior.
contribution: made by mooncitydev